Enable HTTP RPC sockets #871

hiddentao · 2016-06-22T04:34:09Z

This incorporates and replaces #420.

It replaces the --ipcpath CLI parameter with --rpc, allowing for an HTTP RPC hostname (e.g. http://localhost:8545) to be provided. If omitted then IPC is used as the default.
README updated with instructions
Introduce usage of --node- prefix for CLI parameters that are to be passed onto geth/eth.
Warns user that the HTTP option is less secure than IPC
Fix a small bug in solidity compilation error reporting
Incorporates Fixes the node start IPC connection #841 as I needed that to test this properly.

# Conflicts: # interface/client/templates/popupWindows/onboardingScreen.js

# Conflicts: # modules/ethereumNode.js # modules/settings.js # modules/sockets.js

hiddentao · 2016-06-22T05:12:09Z

Ready for review.

hiddentao · 2016-06-27T11:29:48Z

Todo:

Add warning pop-up

hiddentao · 2016-06-28T04:26:27Z

Dialog msg added.

frozeman · 2016-06-29T16:52:52Z

haha :)
Some text improvements:

"....This is less secure than using a local IPC socket - your account passwords will be send in plain text!

Only do this when you secured your HTTP connection, or you know what you are doing."

# Conflicts: # modules/ethereumNode.js # modules/settings.js # modules/sockets.js

hiddentao · 2016-07-09T00:41:45Z

@luclu Fixed directly in develop branch.

frozeman · 2016-07-11T14:10:14Z

modules/settings.js

@@ -136,8 +137,13 @@ for (let optIdx in argv) {
 }

 // some options are shared
+<<<<<<< HEAD


This should be removed

frozeman · 2016-07-11T14:45:47Z

There seems to be an issue, if i put web3.eth.accounts into the interface it doesn't return, and mist wont quit.
Then sometimes when quitting, it will show all the RPC messages, because it can't parse it properly.

I will look more deeply what could be the problem, but if you have any idea @hiddentao please let me know.

EDIT: This seems to happen not all the time, but sometimes that sync requests don't get returned.

hiddentao · 2016-07-13T04:45:21Z

@frozeman Yep, haven't been able to reproduce it yet. If I see it happen I'll investigate further.

# Conflicts: # main.js # modules/ipc/getIpcPath.js # modules/settings.js

# Conflicts: # modules/ethereumNode.js # modules/settings.js

hiddentao · 2016-08-01T12:09:20Z

This is ready to be merged for 0.8.2.

lock · 2018-03-31T23:23:32Z

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

frozeman and others added 8 commits June 16, 2016 16:46

fixed eth start, but crash is not graceful

e8d6801

better socket connection logic, remove master ps logic for eth

7997034

fix splash screen display of state text for eth

dcab76f

better gulp download plugin, remove master passwd stuff once and for all

ec1f4f9

Merge branch 'develop' into fixEthStart

cf440b9

# Conflicts: # interface/client/templates/popupWindows/onboardingScreen.js

HTTP socket working

1c49c38

Merge branch 'fixEthStart' into http_rpc

7fb485f

# Conflicts: # modules/ethereumNode.js # modules/settings.js # modules/sockets.js

minor warning

4be0ebf

hiddentao added the Status: Please review label Jun 22, 2016

hiddentao added this to the 0.8 milestone Jun 22, 2016

hiddentao mentioned this pull request Jun 22, 2016

Possibility to specify IPC path & RPC over HTTP support #420

Closed

hiddentao added Status: In progress and removed Status: Please review labels Jun 22, 2016

hiddentao added 2 commits June 22, 2016 12:42

minor refactor

1072eda

had accidentally deleted stuff from fixEthStart merge

c18eb83

hiddentao added Status: Please review and removed Status: In progress labels Jun 22, 2016

Merge branch 'develop' into http_rpc

f912009

hiddentao added Status: In progress and removed Status: Please review labels Jun 27, 2016

hiddentao added 2 commits June 28, 2016 12:17

Merge branch 'develop' into http_rpc

282b642

show dialog msg if using http rpc

5e40de4

hiddentao added Status: Please review and removed Status: In progress labels Jun 28, 2016

hiddentao added 2 commits June 30, 2016 11:30

update dialog text

112abdf

Merge branch 'develop' into http_rpc

7be7ce6

# Conflicts: # modules/ethereumNode.js # modules/settings.js # modules/sockets.js

Merge branch 'develop' into http_rpc

d3a983b

hiddentao modified the milestones: 0.8.1, 0.8 Jul 11, 2016

frozeman reviewed Jul 11, 2016
View reviewed changes

hiddentao added 2 commits July 12, 2016 12:28

remove git conflict markers

f0013a5

Merge remote-tracking branch 'mist/develop' into http_rpc

a1bef69

This was referenced Jul 13, 2016

Howto MIST connect Node on Diffrent Maschine #963

Closed

Option to let Mist use a remote geth/eth instance on another machine #809

Closed

Question: possible to connect the Wallet to RPC via TCP socket? #493

Closed

hiddentao added 2 commits July 17, 2016 08:47

Merge branch 'develop' into http_rpc

51b25c5

# Conflicts: # main.js # modules/ipc/getIpcPath.js # modules/settings.js

fix merge

d5e7bf0

luclu modified the milestones: 0.8.1, 1.0, 0.8.2 Jul 17, 2016

Merge branch 'develop' into http_rpc

c3cfce6

# Conflicts: # modules/ethereumNode.js # modules/settings.js

luclu added Status: In progress and removed Status: In progress labels Jul 25, 2016

hiddentao merged commit 2f612cd into ethereum:develop Aug 3, 2016

hiddentao removed the Status: Please review label Aug 3, 2016

lock bot locked and limited conversation to collaborators Mar 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable HTTP RPC sockets #871

Enable HTTP RPC sockets #871

hiddentao commented Jun 22, 2016 •

edited

Loading

hiddentao commented Jun 22, 2016

hiddentao commented Jun 27, 2016

hiddentao commented Jun 28, 2016

frozeman commented Jun 29, 2016

hiddentao commented Jul 9, 2016

frozeman Jul 11, 2016

hiddentao Jul 12, 2016

frozeman commented Jul 11, 2016 •

edited

Loading

hiddentao commented Jul 13, 2016

hiddentao commented Aug 1, 2016

lock bot commented Mar 31, 2018

Enable HTTP RPC sockets #871

Enable HTTP RPC sockets #871

Conversation

hiddentao commented Jun 22, 2016 • edited Loading

hiddentao commented Jun 22, 2016

hiddentao commented Jun 27, 2016

hiddentao commented Jun 28, 2016

frozeman commented Jun 29, 2016

hiddentao commented Jul 9, 2016

frozeman Jul 11, 2016

Choose a reason for hiding this comment

hiddentao Jul 12, 2016

Choose a reason for hiding this comment

frozeman commented Jul 11, 2016 • edited Loading

hiddentao commented Jul 13, 2016

hiddentao commented Aug 1, 2016

lock bot commented Mar 31, 2018

hiddentao commented Jun 22, 2016 •

edited

Loading

frozeman commented Jul 11, 2016 •

edited

Loading