Release version v2.1.0 #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update links that point to the releases page from `https://github.com/ethereum/staking-deposit-cli/releases` to `https://github.com/ethereum/eth2.0-deposit-cli/releases`
Update links to the proper releases page
Version bumps packages
Allow 4-character abbreviations for mnemonic when using the existing-mnemonic workflow
Merged
Kick venv cache version
Version bump -> V2.1.0
hwwhww
reviewed
Mar 29, 2022
| @@ -8,7 +8,7 @@ | |||
| }, | |||
| "arg_mnemonic": { | |||
| "help": "The mnemonic that you used to generate your keys. (It is recommended not to use this argument, and wait for the CLI to ask you for your mnemonic as otherwise it will appear in your shell history.)", | |||
| "prompt": "Please enter your mnemonic separated by spaces (\" \")" | |||
| "prompt": "Please enter your mnemonic separated by spaces (\" \"). Note: you only need to enter the first 4 letters of each word if you'd prefer." | |||
There was a problem hiding this comment.
- What do you think about translation in the future release?
- 4-letters abbreviations are not available in Chinese and Korean so we may want to avoid adding translation in these languages.
There was a problem hiding this comment.
As you say, Chinese, Japanese & Korean don't have abbreviated versions. And I'm a little concerned about collisions between 4-letter mnemonics in the romance languages. I've done some testing here, but I'm by no means convinced it can't happen (and trigger the sanity assert) especially considering all the alternate forms of letters (eg moving accents etc).
As such, I think we should avoid translating this bit at all. ie. if you use not-English (tm) you will have to type out the full mnemonic. At a later point if we implement interactive predictive text for words, we can address this.
Actually shortens words for abbrviated mnemonic test vectors
hwwhww
approved these changes
Mar 29, 2022
Re-implement Clarifies when abbreviated words are used
everhusk
pushed a commit
to earthwallet/earth-wallet-cli
that referenced
this pull request
Aug 3, 2023
Release version v2.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
venvcache in CI