Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Upgrade ethereumjs-util to 7.0.0 / Upgrade level-mem to 5.0.1 #116

Merged
merged 1 commit into from
May 1, 2020

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented May 1, 2020

This PR upgrades dependency ethereumjs-util to 7.0.0.

@github-actions
Copy link

github-actions bot commented May 1, 2020

Coverage Status

Coverage remained the same at 94.992% when pulling 3ab453f on upgradeEthJSUtil into b19afe7 on master.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a short look on all usage occasions of the library, no further changes needed, looks good! 😄

"ethereumjs-util": "^6.1.0",
"level-mem": "^3.0.1",
"ethereumjs-util": "^7.0.0",
"level-mem": "^5.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good if you point this out more prominently somewhere if you do such a high-stake major dependency upgrade.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have changed the PR title on this so it won't be forgotten on the release notes.

@holgerd77 holgerd77 changed the title Upgrade ethereumjs-util to 7.0.0 Upgrade ethereumjs-util to 7.0.0 / Upgrade level-mem to 5.0.1 May 1, 2020
@holgerd77 holgerd77 merged commit a2b0b18 into master May 1, 2020
@holgerd77 holgerd77 deleted the upgradeEthJSUtil branch May 1, 2020 19:24
@ryanio ryanio mentioned this pull request May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants