Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Upgrade ethereumjs-util to 7.0.0 / Upgrade level-mem to 5.0.1 #116

Merged
merged 1 commit into from
May 1, 2020
Merged

Upgrade ethereumjs-util to 7.0.0 / Upgrade level-mem to 5.0.1 #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"tsc": "ethereumjs-config-tsc",
"test": "npm run test:node && npm run test:browser",
"test:browser": "npm run build && karma start karma.conf.js",
"test:node": "npm run build && tape -r ts-node/register test/*.ts | tap-prettify -"
"test:node": "npm run build && tape -r ts-node/register test/*.ts"
},
"husky": {
"hooks": {
Expand All @@ -47,11 +47,11 @@
],
"license": "MPL-2.0",
"dependencies": {
"ethereumjs-util": "^6.1.0",
"level-mem": "^3.0.1",
"ethereumjs-util": "^7.0.0",
"level-mem": "^5.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good if you point this out more prominently somewhere if you do such a high-stake major dependency upgrade.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have changed the PR title on this so it won't be forgotten on the release notes.

"level-ws": "^2.0.0",
"readable-stream": "^3.6.0",
"rlp": "^2.2.3",
"rlp": "^2.2.4",
"semaphore-async-await": "^1.5.1"
},
"devDependencies": {
Expand All @@ -70,7 +70,6 @@
"karma-typescript": "^5.0.1",
"nyc": "^15.0.0",
"prettier": "^2.0.2",
"tap-prettify": "^0.0.2",
"tape": "^4.13.2",
"ts-node": "^8.8.1",
"tslint": "^5.18.0",
Expand Down
4 changes: 2 additions & 2 deletions src/util/hex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ export function removeHexPrefix(val: Nibbles): Nibbles {
}

/**
* Returns true if hexprefixed path is for a terminating (leaf) node.
* Returns true if hex-prefixed path is for a terminating (leaf) node.
* @method isTerminator
* @param {Nibbles} key - an hexprefixed array of nibbles
* @param {Nibbles} key - a hex-prefixed array of nibbles
* @private
*/
export function isTerminator(key: Nibbles): boolean {
Expand Down