Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for FigJam; Clean up #43

Merged
merged 5 commits into from
Oct 3, 2022
Merged

Add support for FigJam; Clean up #43

merged 5 commits into from
Oct 3, 2022

Conversation

huayunh
Copy link
Contributor

@huayunh huayunh commented Sep 30, 2022 •
edited
Loading

Fixes #23

Changes proposed in this Pull Request:

  • Added support for FigJam
  • Added changelog
  • Addressed 2 dependabot PRs webpack v5 frustrated me; wrote Use webpack v5 #44 and fingers crossed
  • Verified that all functions work in both Figma and FigJam, light or dark theme.

To Test:

  • Follow the readme instructions
  • To test light / dark theme: switch your system preference theme to light / dark. Figma's UI will update itself to reflect the change. The plugin should also reflect the change

@huayunh huayunh mentioned this pull request Sep 30, 2022
Closed
@daileytj
Copy link
Contributor

Build isn't working for me locally

Screen Shot 2022-09-30 at 11 05 51 AM

@daileytj
Copy link
Contributor

Screen Shot 2022-09-30 at 11 06 26 AM
^^^ Here are your instructions ^^^ but I don't have any such option for "link existing plugin"... just this...
Screen Shot 2022-09-30 at 11 06 55 AM

There is an "import plugin from manifest" option though... ¯_(ツ)_/¯

@huayunh
Copy link
Contributor Author

huayunh commented Sep 30, 2022

Everything should be working now

daileytj
daileytj approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@daileytj daileytj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me now

@huayunh huayunh merged commit 44b3505 into dev Oct 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the bug/23-figjam-n-at branch October 3, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daileytj daileytj daileytj approved these changes

@emclaug2 emclaug2 Awaiting requested review from emclaug2

@jeffvg jeffvg Awaiting requested review from jeffvg

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make variant switcher work for FigJam
2 participants
@huayunh @daileytj