Skip to content

Commit

Permalink
Revert "Add e2e tests with playwright (#8123)"
Browse files Browse the repository at this point in the history
This reverts commit 0df8157.
  • Loading branch information
andig committed Jun 10, 2023
1 parent e177f7f commit 2299306
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 219 deletions.
74 changes: 11 additions & 63 deletions .github/workflows/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,31 +44,15 @@ jobs:
steps:
- uses: actions/checkout@v3

# - uses: actions/setup-go@v4
- uses: erezrokah/setup-go@feat/add_cache_prefix
with:
go-version: ^1.20
cache-key-prefix: build-cache-
id: go

- uses: actions/setup-node@v3
with:
node-version: "18"
cache: "npm"

- name: Install UI
run: make install-ui

- name: Build UI
run: make ui

- name: Build
run: make build

- name: Upload
uses: actions/upload-artifact@v3
with:
name: evcc-binary
path: ./evcc
run: mkdir dist && touch dist/empty && make build

test:
name: Test
Expand Down Expand Up @@ -108,7 +92,7 @@ jobs:
version: latest
args: --timeout 5m

ui:
build-ui:
name: UI
runs-on: ubuntu-latest

Expand All @@ -120,7 +104,7 @@ jobs:
node-version: "18"
cache: "npm"

- name: Install
- name: Install tools
run: make install-ui

- name: Lint
Expand All @@ -129,48 +113,12 @@ jobs:
- name: Test
run: make test-ui

- name: Porcelain
run: |
test -z "$(git status --porcelain)" || (git status; git diff; false)
integration:
name: Integration
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- uses: actions/setup-node@v3
with:
node-version: "18"
cache: "npm"

- name: Install npm
run: npm ci

- run: npx playwright install --with-deps chromium

- name: Wait for Build
uses: lewagon/wait-on-check-action@v1.3.1
with:
ref: ${{ github.event.pull_request.head.sha || github.sha }}
check-name: Build
repo-token: ${{ secrets.GITHUB_TOKEN }}
wait-interval: 10

- uses: actions/download-artifact@v3
with:
name: evcc-binary

- name: Make executable
run: chmod +x evcc

- name: Run tests
run: npx playwright test
- name: Build
run: make ui

- uses: actions/upload-artifact@v3
if: always()
- name: Cache dist
uses: actions/cache/save@v3
id: cache-dist
with:
name: playwright-report
path: playwright-report/
retention-days: 30
path: dist
key: ${{ runner.os }}-${{ github.sha }}-dist
4 changes: 0 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ __debug_bin
!util/templates/**/*.yaml
!package*.json
!evcc.dist.yaml
!tests/**/*.evcc.yaml
evcc
evcc.exe
evcc_*
Expand All @@ -33,6 +32,3 @@ fly.toml
vendor/*
QEMU_EFI.fd
asset-stats.html
/test-results/
/playwright-report/
/playwright/.cache/
6 changes: 1 addition & 5 deletions assets/js/components/Energyflow/Visualization.vue
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
<template>
<div
data-testid="visualization"
class="visualization"
:class="{ 'visualization--ready': visualizationReady }"
>
<div class="visualization" :class="{ 'visualization--ready': visualizationReady }">
<div class="label-scale d-flex">
<div class="d-flex justify-content-start flex-grow-1">
<LabelBar v-bind="labelBarProps('top', 'pvProduction')">
Expand Down
1 change: 0 additions & 1 deletion assets/js/components/Loadpoints.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
<Loadpoint
v-bind="loadpoint"
:id="index + 1"
data-testid="loadpoint"
:vehicles="vehicles"
:smartCostLimit="smartCostLimit"
:smartCostType="smartCostType"
Expand Down
30 changes: 0 additions & 30 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@
"test": "TZ=Europe/Berlin vitest",
"lint": "prettier assets './**/*.{yml,yaml,toml}' --write && eslint assets/**/*.js assets/**/*.vue --fix",
"dev": "vite",
"histoire": "histoire dev",
"playwright": "playwright test --ui"
"histoire": "histoire dev"
},
"main": "index.js",
"dependencies": {
"@babel/core": "^7.17.2",
"@h2d2/shopicons": "^1.2.0",
"@histoire/plugin-vue": "^0.16.1",
"@playwright/test": "^1.34.3",
"@popperjs/core": "^2.11.5",
"@vitejs/plugin-legacy": "^4.0.2",
"@vitejs/plugin-vue": "^4.1.0",
Expand Down
32 changes: 0 additions & 32 deletions playwright.config.js

This file was deleted.

34 changes: 0 additions & 34 deletions tests/basics.evcc.yaml

This file was deleted.

40 changes: 0 additions & 40 deletions tests/basics.spec.js

This file was deleted.

7 changes: 0 additions & 7 deletions tests/utils.js

This file was deleted.

0 comments on commit 2299306

Please sign in to comment.