Add e2e tests with playwright #8123

naltatis · 2023-05-21T14:49:49Z

Introduce end to end tests with playwright.

Tests starts an evcc instance with a prepared *.evcc.yaml file for each test suite.

npm run playwright

Todos:

maybe optimize GitHub actions > maybe reuse evcc build from previous steps

.github/workflows/default.yml

naltatis · 2023-05-26T14:24:45Z

@andig ich hab die Pipeline etwas umgebaut. Lint und Test sind jeweils für UI und Go zusammengefasst. Das spart redundante Installs. Die Integrationstests verwenden nun das Binary was der build Schritt erzeugt. Dadurch ist auch gleich schon sichergestellt, dass wir keinen groben Schnitzer drin haben der das Hochfahren verhindert.

andig

Vielleicht ist das aber auch nicht so schlimm- kannst Du im PR schon sehen wie lange der Build läuft?

.github/workflows/default.yml

naltatis · 2023-05-31T08:44:36Z

Der build Schritt baut nun die komplette Applikation (mit UI). Das Ergebnis wird für den Integrationstest wiederverwendet. Die Laufzeiten sehen gut aus.

Beim Integrationstests geht der Großteil der Zeit für das Vorbereiten des Containers drauf (Systemabhängigkeiten installieren). Die Ausführung der Tests ist relativ schnell.

andig · 2023-06-04T09:50:12Z

Die meiste Zeit hängt in der Playwrightinstallation. Lässt sich die schneller machen?
Falls nein: könnten wir die:

parallel starten
auf UI build warten
binary einschl. UI neu bauen (das ist fix mit dem Go cache)

...und dann playwright starten?

naltatis · 2023-06-04T14:18:34Z

Die Installation beschleunigen ist schwierig. Es gab mal ne Action von Microsoft, die ist aber deprecated https://github.com/marketplace/actions/run-playwright-tests und die aktuelle Empfehlung ist das was wir hier gerade machen.

Hab aber jetzt einen anderen Weg gefunden und lewagon/wait-on-check-action eingebaut. Damit können alle gleichzeitig loslaufen und Integration kann alles vorbereiten was es braucht und wartet lediglich mit der Testausführung bis das Binary Artefakt hochgeladen wurde.

andig · 2023-06-04T15:19:30Z

Klasse- rein damit?!

This reverts commit 0df8157.

This reverts commit 2299306.

* Revert "Add e2e tests with playwright (#8123)" This reverts commit 0df8157. * Revert "Revert "Add e2e tests with playwright (#8123)"" This reverts commit 2299306. * fix nightly/release * fix nightly/release * fix nightly/release --------- Co-authored-by: andig <cpuidle@gmx.de>

This reverts commit 0df8157.

* Revert "Add e2e tests with playwright (#8123)" This reverts commit 0df8157. * Revert "Revert "Add e2e tests with playwright (#8123)"" This reverts commit 2299306. * fix nightly/release * fix nightly/release * fix nightly/release --------- Co-authored-by: andig <cpuidle@gmx.de>

…to UI (#8115) * Plugins: make javascript return values more permissive * Persist targetSoc/Energy, minSoc and target time, remove experimental from minSoc UI * go generate * Fix tests * Update minSoc description * Store settings by index. Show plan outside pv mode. Add help texts. * remove slug * go mock * lint * chore: simplify templates (#8304) * Add e2e tests with playwright (#8123) * Revert "1p3p: let charger handle session stop/restart (#7723)" This reverts commit dd787ce. * mazda2mqtt: document vin required (#8319) * FoxESS: split H1/H3 devices (#7376) Co-authored-by: premultiply <4681172+premultiply@users.noreply.github.com> * Translations update from Hosted Weblate (#8124) * Translated using Weblate (Czech) Currently translated at 37.3% (99 of 265 strings) Co-authored-by: Dusan Suja <bc.suja.dusan@googlemail.com> Translate-URL: https://hosted.weblate.org/projects/evcc/evcc/cs/ Translation: evcc/evcc * Translated using Weblate (Finnish) Currently translated at 100.0% (265 of 265 strings) Co-authored-by: Arna Lepikkö <arna.lepikko@telemail.fi> Translate-URL: https://hosted.weblate.org/projects/evcc/evcc/fi/ Translation: evcc/evcc * Translated using Weblate (German) Currently translated at 100.0% (265 of 265 strings) Co-authored-by: ThinkEV <claas@rootdir.de> Translate-URL: https://hosted.weblate.org/projects/evcc/evcc/de/ Translation: evcc/evcc * Translated using Weblate (Croatian) Currently translated at 100.0% (265 of 265 strings) Translated using Weblate (Slovenian) Currently translated at 100.0% (265 of 265 strings) Co-authored-by: Žiga Deisinger <ziga@deisinger.si> Translate-URL: https://hosted.weblate.org/projects/evcc/evcc/hr/ Translate-URL: https://hosted.weblate.org/projects/evcc/evcc/sl/ Translation: evcc/evcc * Translated using Weblate (Catalan) Currently translated at 100.0% (265 of 265 strings) Co-authored-by: Norbert Poch <npoch@yahoo.com> Translate-URL: https://hosted.weblate.org/projects/evcc/evcc/ca/ Translation: evcc/evcc * Translated using Weblate (Dutch) Currently translated at 76.6% (203 of 265 strings) Translated using Weblate (Dutch) Currently translated at 74.3% (197 of 265 strings) Co-authored-by: Ruben Van Boxem <vanboxem.ruben@gmail.com> Translate-URL: https://hosted.weblate.org/projects/evcc/evcc/nl/ Translation: evcc/evcc * fix toml --------- Co-authored-by: Dusan Suja <bc.suja.dusan@googlemail.com> Co-authored-by: Arna Lepikkö <arna.lepikko@telemail.fi> Co-authored-by: ThinkEV <claas@rootdir.de> Co-authored-by: Žiga Deisinger <ziga@deisinger.si> Co-authored-by: Norbert Poch <npoch@yahoo.com> Co-authored-by: Ruben Van Boxem <vanboxem.ruben@gmail.com> Co-authored-by: premultiply <4681172+premultiply@users.noreply.github.com> * Add OBO Betterman Ion (#8321) Also aligns heartbeat implementations * Enphase: add token auth (firmware D7.x.xxx) and grid (#8247) * Mqtt: fix smartCostLimit topic case (#8328) * Add ISO15118 vehicle template (#8302) * Mqtt: simplify setters * Mqtt: disable message ordering to improve performance * chore: simplify random state generation * Porsche: remove deprecated mobile api (#8349) * Porsche: remove remaining mobile api types * Cupra: add odometer (#8340) * chore: refactor go-stylish * chore: fix stale handler * mazda2mqtt: longer timeout (#8364) * chore: pre-process toml * chore: prevent toml double quotes * Audi: temporarily switch to etron (#8374) * Fix nightly build (#8384) * Update SunSpec templates (#8270) * Revert "Fix nightly build (#8384)" This reverts commit 536dbc9. * Revert "Add e2e tests with playwright (#8123)" This reverts commit 0df8157. * Easee: update Observation IDs (#8391) * Easee: handle smartCharging errors (#8389) * TWC: add non-Tesla vehicle warning (#8329) * TWC: allow loadpoint to wakeup vehicle (#8284) * chore: use gridx consts * Fix ISO15118 vehicle (#8402) Such vehicles would be reported as `(Offline)` previously, as no Soc can be fetched and thus needs to behave as the `offline` template. The SoC is fetched via the charger, so hardcode it to 0 in here * Modbus: add coils (#8385) * OpenEVSE: fix api (#8415) * chore: refactor offline vehicles (#8404) * Easee: wait for api confirmation (#8307) * Revert "Easee: wait for api confirmation (#8307)" This reverts commit ce0e427. * automatically switch session log energy unit (#8371) Show the charged energy in the session log table and details in Wh for values below 1 kWh and in kWh for larger values * Fix nightly/release + integration workflow (#8450) * Revert "Add e2e tests with playwright (#8123)" This reverts commit 0df8157. * Revert "Revert "Add e2e tests with playwright (#8123)"" This reverts commit 2299306. * fix nightly/release * fix nightly/release * fix nightly/release --------- Co-authored-by: andig <cpuidle@gmx.de> * chore: no integration on nightly * chore: no integration on nightly * chore: no integration on nightly * Sessions: filter, monthly sums, paging (#8278) * fmt * Update i18n/en.toml Co-authored-by: Simon Riepl <43091717+savus4@users.noreply.github.com> * Use exp/slices * Use mux consistently * add integration tests --------- Co-authored-by: andig <cpuidle@gmx.de> Co-authored-by: C64Axel <33828760+C64Axel@users.noreply.github.com> Co-authored-by: premultiply <4681172+premultiply@users.noreply.github.com> Co-authored-by: Weblate (bot) <hosted@weblate.org> Co-authored-by: Dusan Suja <bc.suja.dusan@googlemail.com> Co-authored-by: Arna Lepikkö <arna.lepikko@telemail.fi> Co-authored-by: ThinkEV <claas@rootdir.de> Co-authored-by: Žiga Deisinger <ziga@deisinger.si> Co-authored-by: Norbert Poch <npoch@yahoo.com> Co-authored-by: Ruben Van Boxem <vanboxem.ruben@gmail.com> Co-authored-by: salz3n <79696598+salz3n@users.noreply.github.com> Co-authored-by: Daniel Paschke <paschdan@gmail.com> Co-authored-by: Andreas Linde <42185+DerAndereAndi@users.noreply.github.com> Co-authored-by: lex777777 <84906358+lex777777@users.noreply.github.com> Co-authored-by: Oscar <OAltr@users.noreply.github.com> Co-authored-by: Michael Heß <GrimmiMeloni@users.noreply.github.com> Co-authored-by: RTTTC <94727758+RTTTC@users.noreply.github.com> Co-authored-by: kscholty <47229207+kscholty@users.noreply.github.com> Co-authored-by: Jan Alexander <jan.alexander@posteo.de> Co-authored-by: Simon Riepl <43091717+savus4@users.noreply.github.com>

add e2e tests with playwright

9f08f58

naltatis marked this pull request as draft May 21, 2023 14:51

naltatis added 3 commits May 21, 2023 16:52

fmt

db4c22f

gh actions

9946a7a

gh actions

ceb5c64

naltatis marked this pull request as ready for review May 21, 2023 15:17

andig added the infrastructure Basic functionality label May 21, 2023

StefanSchoof reviewed May 21, 2023

View reviewed changes

.github/workflows/default.yml Outdated Show resolved Hide resolved

naltatis added 8 commits May 22, 2023 09:03

use npm cache

4ed2fea

optimize pipeline; no redundant builds

bb7d227

optimize pipeline; no redundant builds

def6e0d

optimize pipeline; no redundant builds

d2d7666

logging

9fec631

logging

24f01ac

make executable

20c46bc

logging

5882232

naltatis requested a review from andig May 30, 2023 10:46

andig reviewed May 30, 2023

View reviewed changes

.github/workflows/default.yml Outdated Show resolved Hide resolved

.github/workflows/default.yml Show resolved Hide resolved

naltatis added 11 commits May 31, 2023 09:37

go build cache instead of up/download binary

00e0d1c

merge

e44cbfb

pipeline

0463b26

split test/lint

8415ad5

browser cache

9aaf3e1

browser cache

b500d7d

playwright test

c42ada4

split

cb78aec

split build & integration

701c28b

split build & integration

c8a1412

cleanup

3f5c225

naltatis added 2 commits June 4, 2023 16:03

run integration parallel, wait between steps

b3a65c7

run integration parallel, wait between steps

240ea4a

naltatis merged commit 0df8157 into master Jun 5, 2023

naltatis deleted the chore/setup_playwright_tests branch June 5, 2023 06:31

salz3n mentioned this pull request Jun 9, 2023

Nightly Build Action ist defekt #8382

Closed

andig added a commit that referenced this pull request Jun 10, 2023

Revert "Add e2e tests with playwright (#8123)"

2299306

This reverts commit 0df8157.

naltatis pushed a commit that referenced this pull request Jun 13, 2023

Revert "Add e2e tests with playwright (#8123)"

3cb6584

This reverts commit 0df8157.

naltatis added a commit that referenced this pull request Jun 13, 2023

Revert "Revert "Add e2e tests with playwright (#8123)""

98246e8

This reverts commit 2299306.

naltatis added a commit that referenced this pull request Jun 14, 2023

Add e2e tests with playwright (#8123)

7b16908

naltatis pushed a commit that referenced this pull request Jun 14, 2023

Revert "Add e2e tests with playwright (#8123)"

c7e2418

This reverts commit 0df8157.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add e2e tests with playwright #8123

Add e2e tests with playwright #8123

naltatis commented May 21, 2023 •

edited

Loading

naltatis commented May 26, 2023

andig left a comment

naltatis commented May 31, 2023

andig commented Jun 4, 2023

naltatis commented Jun 4, 2023

andig commented Jun 4, 2023

Add e2e tests with playwright #8123

Add e2e tests with playwright #8123

Conversation

naltatis commented May 21, 2023 • edited Loading

naltatis commented May 26, 2023

andig left a comment

Choose a reason for hiding this comment

naltatis commented May 31, 2023

andig commented Jun 4, 2023

naltatis commented Jun 4, 2023

andig commented Jun 4, 2023

naltatis commented May 21, 2023 •

edited

Loading