Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple skills affecting ship bonus now condensed in ship browser; confusing and ambiguous. #88

Open
lps1975 opened this issue Apr 6, 2018 · 1 comment

Comments

@lps1975
Copy link

lps1975 commented Apr 6, 2018

3.0.4 unintentionally introduced a nasty little bug in the ship browser that hides important skill bonus details about the ship. Here's a cut-and-pasted example of the Prospect's bonuses as shown in 3.0.4:

--- Traits ---
Prospect bonuses (per skill level):
5% bonus to Mining yield
5% reduction in ship signature radius
5% bonus to Mining yield
5% reduction in Gas Cloud Harvesting duration

As you can see, everything gets lumped in under the term 'Prospect' bonuses, when the bonuses should actually be divided into 'Mining Frigate' bonuses and 'Expedition Frigate' bonuses. (As was the case prior to 3.0.4)

Another quick example just to elaborate, the Buzzard:

--- Traits ---
Buzzard bonuses (per skill level):
5% bonus to kinetic Light Missile and Rocket damage
5% bonus to Light Missile and Rocket Launcher rate of fire
10% bonus to Core and Combat Scanner Probe strength
10% reduction in time required for Survey Probe scans
20% reduction in Cloaking Devices CPU requirement

Those should be split into Caldari Frigate and Covert Ops.

I haven't looked at the code yet (I'm not a C# guy) but this feels like perhaps a different method was used to obtain the list of skills for a ship, or string interpolation was changed. My gut tells me it would be a straight-forward fix, possibly a simple reversion back to previous code.

@lps1975
Copy link
Author

lps1975 commented Sep 4, 2018

Can you please briefly explain why this issue was closed?

NevarrTivianne pushed a commit to NevarrTivianne/evemon that referenced this issue Apr 3, 2021
This one should be safe to integrate, as CacheStyle has no consumers.

I am still looking at evemondevteam#13 but would like to hammer the more pressing bugs first before undertaking a big rewrite of the ESI front end.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant