Merge pull request #630 from prog-supdex/fix_lefthook_env

fix: handle LEFTHOOK_QUIET when there is no skip_output in config

internal/log/skip_settings.go

@@ -27,10 +27,11 @@ func (s *SkipSettings) ApplySettings(tags string, skipOutput interface{}) {
 		for _, skipOption := range typedSkipOutput {
 			s.applySetting(skipOption.(string))
 		}
-		if tags != "" {
-			for _, skipOption := range strings.Split(tags, ",") {
-				s.applySetting(skipOption)
-			}
+	}
+
+	if tags != "" {
+		for _, skipOption := range strings.Split(tags, ",") {
+			s.applySetting(skipOption)
 		}
 	}
 }

internal/log/skip_settings_test.go

@@ -7,25 +7,30 @@ import (
 
 func TestSkipSetting(t *testing.T) {
 	for i, tt := range [...]struct {
+		tags     string
 		settings interface{}
 		results  map[string]bool
 	}{
 		{
+			tags:     "",
 			settings: []interface{}{},
 			results:  map[string]bool{},
 		},
 		{
+			tags:     "",
 			settings: false,
 			results:  map[string]bool{},
 		},
 		{
+			tags:     "",
 			settings: []interface{}{"failure", "execution"},
 			results: map[string]bool{
 				"failure":   true,
 				"execution": true,
 			},
 		},
 		{
+			tags: "",
 			settings: []interface{}{
 				"meta",
 				"summary",
@@ -50,6 +55,7 @@ func TestSkipSetting(t *testing.T) {
 			},
 		},
 		{
+			tags:     "",
 			settings: true,
 			results: map[string]bool{
 				"meta":           true,
@@ -63,11 +69,26 @@ func TestSkipSetting(t *testing.T) {
 				"empty_summary":  true,
 			},
 		},
+		{
+			tags:     "meta,summary,success,skips,empty_summary",
+			settings: nil,
+			results: map[string]bool{
+				"meta":           true,
+				"summary":        true,
+				"success":        true,
+				"failure":        false,
+				"skips":          true,
+				"execution":      false,
+				"execution_out":  false,
+				"execution_info": false,
+				"empty_summary":  true,
+			},
+		},
 	} {
 		t.Run(fmt.Sprintf("%d", i), func(t *testing.T) {
 			var settings SkipSettings
 
-			(&settings).ApplySettings("", tt.settings)
+			(&settings).ApplySettings(tt.tags, tt.settings)
 
 			if settings.SkipMeta() != tt.results["meta"] {
 				t.Errorf("expected SkipMeta to be %v", tt.results["meta"])