fix: handle LEFTHOOK_QUIET when there is no skip_output in config #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrexox
approved these changes
Feb 15, 2024
internal/log/skip_settings_test.go
Outdated
Comment on lines
110
to
125
| t.Run("ApplySettings with non-empty tags and nil skipOutput", func(t *testing.T) { | ||
| var settings SkipSettings | ||
| (&settings).ApplySettings("meta,success", nil) | ||
|
|
||
| if !settings.SkipMeta() { | ||
| t.Errorf("expected SkipMeta to be true") | ||
| } | ||
|
|
||
| if !settings.SkipSuccess() { | ||
| t.Errorf("expected SkipSuccess to be true") | ||
| } | ||
|
|
||
| if settings.SkipFailure() { | ||
| t.Errorf("expected SkipFailure to be false") | ||
| } | ||
| }) |
There was a problem hiding this comment.
What if we extend the previous test to include tags variable? I think we can add a testcase with tags: "meta,success" and settings: nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #623
⚡ Summary
Handles situations when only
LEFTHOOK_QUIETexists, withoutskip_outputin thelefthook.ymlfile☑️ Checklist