Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: convert DefaultGasAdjustment to var #44

Merged
merged 3 commits into from
Aug 15, 2023
Merged

chore: convert DefaultGasAdjustment to var #44

merged 3 commits into from
Aug 15, 2023

Conversation

GAtom22
Copy link

@GAtom22 GAtom22 commented Aug 15, 2023

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Aug 15, 2023
Vvaradinov
Vvaradinov approved these changes Aug 15, 2023
View reviewed changes
Copy link

@Vvaradinov Vvaradinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GAtom22 GAtom22 merged commit a3b98a4 into ledger/v0.47.x Aug 15, 2023
21 of 22 checks passed
@GAtom22 GAtom22 deleted the GAtom22/gas-adj branch August 15, 2023 14:51
@GAtom22
Copy link
Author

GAtom22 commented Nov 22, 2023

https://github.com/Mergifyio backport evmos/v0.50.x

@mergify Mergify
Copy link

mergify bot commented Nov 22, 2023 •
edited
Loading

backport evmos/v0.50.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 22, 2023
@GAtom22 @mergify
chore: convert DefaultGasAdjustment to var (#44)
1d4846e 
(cherry picked from commit a3b98a4)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Nov 22, 2023
Merged
GAtom22 added a commit that referenced this pull request Nov 22, 2023
@mergify @GAtom22
chore: convert DefaultGasAdjustment to var (backport #44) (#49)
1da5fb0 
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
GAtom22 added a commit that referenced this pull request Feb 15, 2024
@GAtom22
chore: convert DefaultGasAdjustment to var (#44)
8d885d7
GAtom22 added a commit that referenced this pull request May 29, 2024
@GAtom22
chore: convert DefaultGasAdjustment to var (#44)
65d5364
GAtom22 added a commit that referenced this pull request Jun 5, 2024
@mergify @GAtom22
chore: convert DefaultGasAdjustment to var (backport #44) (#49)
1e70153 
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
GAtom22 added a commit that referenced this pull request Jun 20, 2024
@GAtom22
chore: convert DefaultGasAdjustment to var (#44)
f346110
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
GAtom22 added a commit that referenced this pull request Jul 18, 2024
@mergify @GAtom22
chore: convert DefaultGasAdjustment to var (backport #44) (#49)
7d5e70c 
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
GAtom22 added a commit that referenced this pull request Jul 30, 2024
@GAtom22
chore: convert DefaultGasAdjustment to var (#44)
8ff9da8
GAtom22 added a commit that referenced this pull request Aug 7, 2024
@mergify @GAtom22
chore: convert DefaultGasAdjustment to var (backport #44) (#49)
e1be35f 
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vvaradinov Vvaradinov Vvaradinov approved these changes

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann

@0xstepit 0xstepit Awaiting requested review from 0xstepit

Assignees
No one assigned
Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GAtom22 @Vvaradinov