-
Notifications
You must be signed in to change notification settings - Fork 562
fix: avoid duplicate register proto type in evm & feemarket #1586
Conversation
08db13a
to
f6ef106
Compare
f6ef106
to
e4fb667
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vvaradinov Evm migrate is fixed, but recent merged feemarket also get same issue.
e4fb667
to
e42b378
Compare
Hey @mmsqe great work on this! Can you check out evmos/evmos#1219 and try to localize the legacy x/params methods to the migrations folder? |
Roger that, just want to list out changes first to avoid duplicate work. |
29e09df
to
314bb28
Compare
@Vvaradinov Emit eventEthereumTx in AnteHandle is different from grpc MsgServer one, need to revert #1544 to unblock the test |
I'm currently investigating this in a separate PR #1592. It could require reverting to the old |
Thanks, I just revert part of handle for typed event too, but we need keep subspace for query compatible with version before migrate, otherwise need sth like #1601 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1586 +/- ##
==========================================
+ Coverage 68.31% 68.33% +0.01%
==========================================
Files 110 110
Lines 10087 10171 +84
==========================================
+ Hits 6891 6950 +59
- Misses 2793 2818 +25
Partials 403 403
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @mmsqe.
Closes: #XXX
Description
This PR mainly focus duplicate register proto type in evm & feemarket, also
ethermint.feemarket.v1.EventFeeMarket
with compatible type"
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)