Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: failing RPC tests caused by TypedEvents #1592

Closed
wants to merge 8 commits into from

Conversation

Vvaradinov
Copy link
Contributor

@Vvaradinov Vvaradinov commented Jan 6, 2023

Closes: ENG-1266

Description

RPC tests unexpectedly fails. due to the migration of event emitting to TypedEvents.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@linear
Copy link

linear bot commented Jan 6, 2023

ENG-1266 RPC method GetFilterChanges tests fail

Started breaking on the TypedEvents PR on Ethermint.

Timeouts are constantly being hit on the entire RPC test suite.

@github-actions github-actions bot added the Type: Build codebase build process label Jan 6, 2023
@github-actions github-actions bot added the Type: Tests issues and PR related to tests label Jan 6, 2023
app/ante/setup.go Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #1592 (2646742) into main (57ed355) will decrease coverage by 0.02%.
The diff coverage is 62.50%.

❗ Current head 2646742 differs from pull request most recent head f972c00. Consider uploading reports for the commit f972c00 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1592      +/-   ##
==========================================
- Coverage   68.19%   68.17%   -0.03%     
==========================================
  Files         110      110              
  Lines       10087    10090       +3     
==========================================
  Hits         6879     6879              
- Misses       2801     2803       +2     
- Partials      407      408       +1     
Impacted Files Coverage Δ
app/ante/setup.go 79.48% <62.50%> (-2.10%) ⬇️

app/ante/setup.go Fixed Show fixed Hide fixed
@Vvaradinov Vvaradinov changed the title fix: failing GetFilterChanges rpc tests fix: failing RPC tests caused by TypedEvents Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Build codebase build process Type: Tests issues and PR related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants