This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 562
fix: failing RPC tests caused by TypedEvents #1592
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-1266 RPC method GetFilterChanges tests fail
Started breaking on the Timeouts are constantly being hit on the entire RPC test suite. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1592 +/- ##
==========================================
- Coverage 68.19% 68.17% -0.03%
==========================================
Files 110 110
Lines 10087 10090 +3
==========================================
Hits 6879 6879
- Misses 2801 2803 +2
- Partials 407 408 +1
|
Vvaradinov
changed the title
fix: failing GetFilterChanges rpc tests
fix: failing RPC tests caused by TypedEvents
Jan 10, 2023
This was referenced Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: ENG-1266
Description
RPC tests unexpectedly fails. due to the migration of event emitting to TypedEvents.
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)