Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use finalizers to support runner-unregistration #146

Closed
davidkarlsen opened this issue Dec 31, 2020 · 0 comments · Fixed by #147
Closed

Use finalizers to support runner-unregistration #146

davidkarlsen opened this issue Dec 31, 2020 · 0 comments · Fixed by #147
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@davidkarlsen
Copy link
Collaborator

Avoid actions/runner#752 by adding finalizer to the pod.
This helps doing unregistration from the controller rather than by each pod.
Ultimately this will support achieving #75 in order to avoid exposure of tokens with high privileges to the runners/pod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant