Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support app-based authentication with JWT and install-tokens #75

Closed
davidkarlsen opened this issue Aug 9, 2020 · 0 comments · Fixed by #153
Closed

Support app-based authentication with JWT and install-tokens #75

davidkarlsen opened this issue Aug 9, 2020 · 0 comments · Fixed by #153
Labels
documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code help wanted Extra attention is needed
Milestone

Comments

@davidkarlsen
Copy link
Collaborator

davidkarlsen commented Aug 9, 2020

Add support for several auth mechs (to avoid simple static tokens), which can be handled by https://github.com/palantir/go-githubapp.

relevant requested feature in the runner api: actions/runner#752

The goal is to avoid use of PAT both for the controller and the pods.
Keep CRD as today, but create registration tokens and put them in the referenced secret, check if they can be re-used or not. Annotate the secret with the expiry.

Add a finalizer to the pod, this can be called in order to unregister the runner which avoids actions/runner#752

@davidkarlsen davidkarlsen added enhancement New feature or request go Pull requests that update Go code help wanted Extra attention is needed documentation Improvements or additions to documentation labels Aug 9, 2020
@davidkarlsen davidkarlsen changed the title Support app-based authentication with JWT and installtokens Support app-based authentication with JWT and install-tokens Dec 31, 2020
@davidkarlsen davidkarlsen added this to the v0.8.0 milestone Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant