Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github-app auth-mode #153

Merged
merged 17 commits into from
Jan 2, 2021
Merged

Github-app auth-mode #153

merged 17 commits into from
Jan 2, 2021

Conversation

davidkarlsen
Copy link
Collaborator

Fixes #75. Allow operator to authenticate as github-app. This eliminates the need to use PATs per pool, while still being compatible with the existing PAT-mode.

@davidkarlsen davidkarlsen added the enhancement New feature or request label Jan 2, 2021
@davidkarlsen davidkarlsen added this to the v0.8.0 milestone Jan 2, 2021
@davidkarlsen davidkarlsen self-assigned this Jan 2, 2021
@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #153 (a984e8e) into master (fa9402e) will decrease coverage by 0.04%.
The diff coverage is 38.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   61.18%   61.14%   -0.03%     
==========================================
  Files           2        2              
  Lines         188      193       +5     
==========================================
+ Hits          115      118       +3     
- Misses         53       55       +2     
  Partials       20       20              
Impacted Files Coverage Δ
controllers/githubactionrunner_controller.go 54.82% <38.89%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa9402e...a984e8e. Read the comment docs.

@davidkarlsen davidkarlsen merged commit 1c405cf into master Jan 2, 2021
@davidkarlsen davidkarlsen deleted the authModels branch January 2, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support app-based authentication with JWT and install-tokens
1 participant