-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unregister and delete completed pods #346
Conversation
Signed-off-by: Lukas Hybner <git@hybner.net>
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
- Coverage 66.56% 65.48% -1.08%
==========================================
Files 3 3
Lines 299 307 +8
==========================================
+ Hits 199 201 +2
- Misses 74 80 +6
Partials 26 26
Continue to review full report at Codecov.
|
Signed-off-by: Lukas Hybner <git@hybner.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@lukashybner-ext90548 Can you try this tag:
|
I tried the tag v0.9.4-59-gcd45f46 and it works correctly. |
Thank you for the feedback and your contribution. |
Github Actions has new feature - ephemeral runners. Which means that when workflow ends then pods end with completed status. So this changes is unregister and delete pods with completed status.