Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister and delete completed pods #346

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Unregister and delete completed pods #346

merged 2 commits into from
Oct 20, 2021

Conversation

lukashybner-ext90548
Copy link
Contributor

Github Actions has new feature - ephemeral runners. Which means that when workflow ends then pods end with completed status. So this changes is unregister and delete pods with completed status.

Signed-off-by: Lukas Hybner <git@hybner.net>
@lukashybner-ext90548 lukashybner-ext90548 marked this pull request as ready for review October 18, 2021 13:20
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #346 (210c537) into master (7022404) will decrease coverage by 1.09%.
The diff coverage is 36.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   66.56%   65.48%   -1.08%     
==========================================
  Files           3        3              
  Lines         299      307       +8     
==========================================
+ Hits          199      201       +2     
- Misses         74       80       +6     
  Partials       26       26              
Impacted Files Coverage Δ
controllers/githubactionrunner_controller.go 58.11% <0.00%> (-1.41%) ⬇️
controllers/podrunner_types.go 100.00% <100.00%> (ø)
controllers/podutil.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7022404...210c537. Read the comment docs.

Signed-off-by: Lukas Hybner <git@hybner.net>
Copy link
Collaborator

@davidkarlsen davidkarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidkarlsen davidkarlsen merged commit cd45f46 into evryfs:master Oct 20, 2021
@davidkarlsen
Copy link
Collaborator

davidkarlsen commented Oct 20, 2021

@lukashybner-ext90548 Can you try this tag:
https://quay.io/repository/evryfs/github-actions-runner-operator?tab=tags - v0.9.4-59-gcd45f46 - if it works as intended I can create a final release of it.

Quay is the best place to build, store, and distribute your containers. Public repositories are always free.

@lukashybner-ext90548
Copy link
Contributor Author

I tried the tag v0.9.4-59-gcd45f46 and it works correctly.

@davidkarlsen
Copy link
Collaborator

Thank you for the feedback and your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants