Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make timeout configurable #47

Closed
Tracked by #819
tkilias opened this issue Jun 2, 2023 · 1 comment · Fixed by #49
Closed
Tracked by #819

Make timeout configurable #47

tkilias opened this issue Jun 2, 2023 · 1 comment · Fixed by #49
Assignees
@Nicoretti @tkilias
Labels
bug Unwanted / harmful behavior

Comments

@tkilias
Copy link
Collaborator

tkilias commented Jun 2, 2023

Background

  • Since, adding the Pandas 2 support to the script-languages-release repo, we have 300+ more tests which increase the CI execution time to above 2 hours
  • For uploading the container as release artifact to Github, we currently use the Github Access Token of the Workflow run
  • The Github Access Token of the Workflow run is only valid until the workflow ends
  • If the timeout is causing the Workflow run to end, the AWS Code Build run can't upload the container as release artifact
  • By making this timeout configurable in a config file, we can avoid changing the code of this repo, if further increases should be necessary.

script-languages-container-ci-setup/exasol_script_languages_container_ci_setup/lib/aws_access.py

Line 125 in 03505cd

timeout_time_in_seconds = 60 * 60 * 2 # We wait for maximal 2h + (something)

@tkilias tkilias added the bug Unwanted / harmful behavior label Jun 2, 2023
@tkilias tkilias mentioned this issue Jun 5, 2023
Closed
3 tasks
@tkilias tkilias self-assigned this Jun 8, 2023
@tkilias tkilias mentioned this issue Jun 8, 2023
Merged
@ckunki
Copy link

ckunki commented Jun 14, 2023

Waiting for AWS PR

@ckunki ckunki added blocked:yes Currently blocked by another ticket and removed blocked:yes Currently blocked by another ticket labels Jun 14, 2023
@Nicoretti Nicoretti self-assigned this Jun 21, 2023
tkilias added a commit that referenced this issue Jun 23, 2023
@tkilias @Nicoretti
#47: Made release timeout configurable (#49)
3d1bcbb 
* Using Pydantic for modeling the Config
* Sorted the tests into unit_tests and integration_tests
* Added CLI parameters for config-file and timeout

Co-authored-by: Nicola Coretti <nico.coretti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nicoretti Nicoretti

@tkilias tkilias

Labels
bug Unwanted / harmful behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#47: Make release timeout configurable exasol/script-languages-container-ci-setup
3 participants
@Nicoretti @tkilias @ckunki