Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#47: Make release timeout configurable #49

Merged
merged 13 commits into from
Jun 23, 2023
Merged

#47: Make release timeout configurable #49

merged 13 commits into from
Jun 23, 2023

Conversation

tkilias
Copy link
Collaborator

@tkilias tkilias commented Jun 8, 2023 •
edited
Loading

Fixes #47

  • Using Pydantic for modeling the Config
  • Sorting the test into unit_tests and integration_tests
  • Add parameter timeout_time_in_seconds to aws_access.start_codebuild
  • Add boto mock tests for AWSAccess

@tkilias tkilias temporarily deployed to AWS June 12, 2023 07:42 — with GitHub Actions Inactive
@tkilias tkilias force-pushed the bug/47_make_timeout_configurable branch from 474d923 to a2e3eee Compare June 12, 2023 17:57
@tkilias tkilias temporarily deployed to AWS June 12, 2023 17:57 — with GitHub Actions Inactive
@tkilias tkilias changed the base branch from main to refactoring/50_aws_abstraction June 12, 2023 17:58
@tkilias tkilias changed the base branch from refactoring/50_aws_abstraction to main June 12, 2023 17:59
@tkilias tkilias changed the base branch from main to refactoring/50_aws_abstraction June 12, 2023 17:59
Base automatically changed from refactoring/50_aws_abstraction to main June 16, 2023 08:27
tkilias added 7 commits June 16, 2023 11:38
@tkilias
- Using Pydantic for modeling the Config
dc12402 
- Sorting the test into unit_tests and integration_tests
- Add parameter timeout_time_in_seconds to aws_access.start_codebuild
- Add boto mock tests for AWSAccess
@tkilias
Added shallow abstraction layer for boto which only implements what i…
9838625 
…s needed by this project

- Moved AwcAccess under module aws
@tkilias
Refactored AwsAccess to us shallow abstraction layer for boto
9097f09
@tkilias
Replaced direct MagicMock instantiation with create_autospec to catch…
309c2e5 
… wrong usage of methods of the mocked class
@tkilias
Added timeout_in_seconds to start_ci_build.py and adjusted the name e…
c12b6c3 
…verywhere else
@tkilias
Fix aws abstraction and AWSAccess
3f2664a
@tkilias
Adapted cli parameters for config-file and timeout
724e112
@tkilias tkilias force-pushed the bug/47_make_timeout_configurable branch from a2e3eee to 724e112 Compare June 16, 2023 09:41
@tkilias tkilias temporarily deployed to AWS June 16, 2023 09:41 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to AWS June 20, 2023 12:50 — with GitHub Actions Inactive
@Nicoretti Nicoretti self-requested a review June 21, 2023 10:46
Nicoretti
Nicoretti previously approved these changes Jun 21, 2023
View reviewed changes
exasol_script_languages_container_ci_setup/lib/config/pydantic_model_generator.py Outdated Show resolved Hide resolved
test/unit_tests/test_config_data_model.py Outdated Show resolved Hide resolved
test/unit_tests/test_pydantic_model_generator.py Outdated Show resolved Hide resolved
@tkilias tkilias temporarily deployed to AWS June 21, 2023 14:53 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to AWS June 22, 2023 09:57 — with GitHub Actions Inactive
Nicoretti
Nicoretti reviewed Jun 23, 2023
View reviewed changes
test/unit_tests/test_config_data_model.py Outdated Show resolved Hide resolved
test/unit_tests/conftest.py Outdated Show resolved Hide resolved
@tkilias @Nicoretti
Apply suggestions from code review
ced2d71 
Co-authored-by: Nicola Coretti <nico.coretti@gmail.com>
Nicoretti
Nicoretti reviewed Jun 23, 2023
View reviewed changes
test/unit_tests/test_config_data_model.py Outdated
Comment on lines 27 to 29
def test_serialization(expected_config, expected_config_json):
actual_json = expected_config.json(indent=4)
print(actual_json)
assert actual_json == expected_config_json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed to update the test with the new fixture name

@tkilias tkilias temporarily deployed to AWS June 23, 2023 09:44 — with GitHub Actions Inactive
@tkilias tkilias merged commit 3d1bcbb into main Jun 23, 2023
@tkilias tkilias deleted the bug/47_make_timeout_configurable branch June 23, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicoretti Nicoretti Nicoretti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make timeout configurable
2 participants
@tkilias @Nicoretti