Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward JAR options without changing order to classpath #990

Closed
tomuben opened this issue Oct 21, 2024 · 0 comments · Fixed by #994
Closed

Forward JAR options without changing order to classpath #990

tomuben opened this issue Oct 21, 2024 · 0 comments · Fixed by #994
Assignees
Labels
refactoring Code improvement without behavior change

Comments

@tomuben
Copy link
Collaborator

tomuben commented Oct 21, 2024

Background

The %jar option for Java UDF references external JAR files, see https://docs.exasol.com/db/latest/database_concepts/udf_scripts/adding_new_packages_script_languages.htm#AddingJavafilesjartoaJavaUDF

File paths under Linux support white spaces. However, we don't want to break compatiblity with the old parser syntax which always trimmed the JAR file path.

Also, the current implementation collects the JAR options in a std::set, in order to avoid duplicates. However, the classpath entries are then in an alphabetical order. The user looses control about the order of the classpath entries.

Acceptance Criteria

  1. Change the convert.cc implementation which process the JAR option and check for escape sequences "\ " and "\t".
  2. Trim white spaces which are not escaped
  3. Collect jar paths in a list and not in a set.
  4. Adjust JavaContainer to forward classpaths in user given order
@tomuben tomuben self-assigned this Oct 21, 2024
@tomuben tomuben added the refactoring Code improvement without behavior change label Oct 21, 2024
@tomuben tomuben changed the title Support escape sequence for ending white spaces in JAR option Forward JAR options as is to classpath Oct 23, 2024
@tomuben tomuben changed the title Forward JAR options as is to classpath Forward JAR options without changing order to classpath Oct 23, 2024
tomuben added a commit to exasol/script-languages that referenced this issue Oct 24, 2024
tomuben added a commit to exasol/script-languages that referenced this issue Oct 25, 2024
related to exasol/script-languages-release#990

---------

Co-authored-by: Torsten Kilias <tkilias@users.noreply.github.com>
tomuben added a commit to exasol/script-languages that referenced this issue Oct 29, 2024
tomuben added a commit that referenced this issue Oct 29, 2024
…n UDF client

- #990: Forward JAR options without changing order to classpath
- #989: Trim script class and import script options
- #993: Added escape sequence for backslash in new Script Options parser
tomuben added a commit that referenced this issue Oct 29, 2024
closes #990: Forward JAR options without changing order to classpath
closes #989: Trim script class and import script options
closes #993: Added escape sequence for backslash in new Script Options parser
closes #986: Added environment variable for new ScriptOptionsLine parser in UDF client
@tomuben tomuben closed this as completed Oct 29, 2024
@tomuben tomuben linked a pull request Oct 29, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant