#990: Forward jar options without changing order #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicoretti
reviewed
Oct 24, 2024
exaudfclient/base/javacontainer/script_options/converter_legacy.h
Outdated
Show resolved
Hide resolved
exaudfclient/base/javacontainer/script_options/extractor_impl.h
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Oct 24, 2024
exaudfclient/base/javacontainer/script_options/converter_legacy.cc
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Oct 24, 2024
exaudfclient/base/javacontainer/test/cpp/javacontainer_ctpg_test.cc
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Oct 24, 2024
tkilias
reviewed
Oct 24, 2024
exaudfclient/base/javacontainer/script_options/test/converter_test.cc
Outdated
Show resolved
Hide resolved
2. renamed javacontainer_ctpg_test.cc => javacontainer_extractor_v2_test.cc 3. Moved test `basic_jars_ordering` to javacontainer_test.cc
…ractor-legacy 2. Improved UML diagrams
tkilias
reviewed
Oct 25, 2024
tkilias
reviewed
Oct 25, 2024
tkilias
reviewed
Oct 25, 2024
tkilias
reviewed
Oct 25, 2024
tkilias
reviewed
Oct 25, 2024
tkilias
reviewed
Oct 25, 2024
tkilias
approved these changes
Oct 25, 2024
tomuben
deleted the
refactoring/990_forward_jar_options_without_changing_order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to exasol/script-languages-release#990
Handling trailing whitespaces will be fixed in a different PR