Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ IMPROVE: Add support for Svelte chunks #32

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

wlach
Copy link
Contributor

@wlach wlach commented Jul 13, 2021

Currently the syntax highlighting isn't quite right, probably
related to a bug in the underlying Svelte highlighter for vscode:

sveltejs/language-tools#1094

I'd like to fix the above issue before asking this to be merged, but
I thought I'd file this initial PR for feedback.

Currently the syntax highlighting isn't quite right, probably
related to a bug in the underlying Svelte highlighter for vscode:

sveltejs/language-tools#1094

I'd like to fix the above issue before asking this to be merged, but
I thought I'd file this initial PR for feedback.
@welcome
Copy link

welcome bot commented Jul 13, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

cheers will have a check when you are ready to merge, but looks about right

@wlach wlach marked this pull request as ready for review July 16, 2021 13:54
@wlach
Copy link
Contributor Author

wlach commented Jul 16, 2021

I rabbitholed a bunch on why this wasn't working and am now pretty certain there's no issue with this plugin, the problem seems to be a limitation in VSCode which applies equally to markdown documents as it does to MyST ones. I'm sure it'll be figured out one way or another, but in the mean time I see no reason to delay merging this PR. Once the upstream issue(s) are fixed svelte syntax highlighting should start working as expected. In the mean time I think the incorrect syntax highlighting is still slightly preferable to not doing anything for these types of code chunks.

@chrisjsewell chrisjsewell changed the title Add support for Svelte chunks ✨ IMPROVE: Add support for Svelte chunks Mar 7, 2022
@chrisjsewell chrisjsewell merged commit c5b209c into executablebooks:master Mar 7, 2022
@welcome
Copy link

welcome bot commented Mar 7, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@wlach wlach deleted the svelte branch March 13, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants