Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat exercise config files #149

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Reformat exercise config files #149

merged 1 commit into from
Dec 21, 2022

Conversation

kytrinyx
Copy link
Member

@kytrinyx kytrinyx commented Dec 4, 2022

This runs the bin/configlet fmt --update command to
reformat the exercise configs.

@vordimous
Copy link
Contributor

@kytrinyx I added #156 to address this for all new exercises. I ran the configlet fmt command and it wanted to remove all of the "icon" attributes. Is there a better place for me to put them?

@kytrinyx
Copy link
Member Author

Oh, the icon attribute is a great question. @ErikSchierboom @ee7 do you know where icon is meant to live?

@ErikSchierboom
Copy link
Member

Oh, the icon attribute is a great question. @ErikSchierboom @ee7 do you know where icon is meant to live?

I think this is a bug. I'll fix it tomorrow.

@ErikSchierboom
Copy link
Member

PR submitted: exercism/configlet#716

@ee7
Copy link
Member

ee7 commented Dec 15, 2022

I ran the configlet fmt command and it wanted to remove all of the "icon" attributes.

I've just released configlet 4.0.0-beta.9.

After running fetch-configlet to download the new version, running configlet fmt should no longer remove the icon key/value pair. Please let me know if there's still a problem. Thanks for the bug report.

@kytrinyx
Copy link
Member Author

Thank you @ee7.

This runs the `bin/configlet fmt --update` command to
reformat the exercise configs.
@kytrinyx
Copy link
Member Author

I've redone the formatting and force pushed to this branch to update the PR.

@vordimous vordimous merged commit 978b5b5 into main Dec 21, 2022
@vordimous vordimous deleted the format-exercise-configs branch December 21, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants