fmt, lint: support icon key for practice exercise config.json
#716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
force-pushed
the
allow-icon-for-practice-exercises
branch
from
88321d0
to
7225213
Compare
Merged
The spec previously specified the `icon` key only for a concept exercise, but a practice exercise config.json file can contain this key too [1]. [1] exercism/docs@7e4d87703432
ee7
force-pushed
the
allow-icon-for-practice-exercises
branch
from
7225213
to
499a151
Compare
ee7
changed the title
icon key for practice exercisesicon key for practice exercise config.json
Match the key ordering in the spec.
We should have added this in c7b14f7.
ee7
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See exercism/docs#421