Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch-configlet.ps1: "Cannot validate argument" error #839

Closed
ee7 opened this issue Nov 26, 2023 · 3 comments · Fixed by #841
Closed

fetch-configlet.ps1: "Cannot validate argument" error #839

ee7 opened this issue Nov 26, 2023 · 3 comments · Fixed by #841
Assignees
@ErikSchierboom

Comments

@ee7
Copy link
Member

ee7 commented Nov 26, 2023 •
edited
Loading

From a forum thread:

bin$ pwsh ./fetch-configlet.ps1
Invoke-WebRequest: /mnt/c/Users/bugma/Source/Repos/3rdParty/euphoria/bin/fetch-configlet.ps1:29
Line |
  29 |  Invoke-WebRequest -Uri $downloadUrl -OutFile $outputFile @requestOpts
     |                         ~~~~~~~~~~~~
     | Cannot validate argument on parameter 'Uri'. The argument is null or
     | empty. Provide an argument that is not null or empty, and then try
     | the command again.

This looks different from the error in #786.
@ErikSchierboom ErikSchierboom mentioned this issue Dec 5, 2023
Merged
@ErikSchierboom
Copy link
Member

See #841

@ee7 ee7 closed this as completed in #841 Dec 15, 2023
ee7 pushed a commit that referenced this issue Dec 15, 2023
@ErikSchierboom
fetch-configlet.ps1: fix for newer PowerShell versions (#841)
2630458 
Under some conditions, running the fetch-configlet PowerShell script
could now produce an error like the below:

    $ pwsh ./fetch-configlet.ps1
    Invoke-WebRequest: /mnt/c/Users/bugma/Source/Repos/3rdParty/euphoria/bin/fetch-configlet.ps1:29
    Line |
      29 |  Invoke-WebRequest -Uri $downloadUrl -OutFile $outputFile @requestOpts
         |                         ~~~~~~~~~~~~
         | Cannot validate argument on parameter 'Uri'. The argument is null or
         | empty. Provide an argument that is not null or empty, and then try
         | the command again.

Fix that, and make the script more similar to the bash one.

Changes:

- Fix command chaining

- Move $arch closer to place of use

- Use name field to exactly match filename

- Test if script is run from repo root

- Add message for downloading

- Replace broken expand-archive with ZipFile

- Use explicit output filename

- Output download info

Closes: #839
@ee7 ee7 mentioned this issue Dec 15, 2023
Open
@ee7
Copy link
Member Author

ee7 commented Jan 3, 2024

@ErikSchierboom do you want to sync the fetch-configlet scripts Exercism-wide?

@ErikSchierboom
Copy link
Member

Yes, I'll do that.

This was referenced Jan 3, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 3, 2024
Open
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErikSchierboom ErikSchierboom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fetch-configlet.ps1: fix for newer PowerShell versions exercism/configlet
2 participants
@ErikSchierboom @ee7