Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch-configlet.ps1: fix for newer PowerShell versions #841

Merged
merged 8 commits into from
Dec 15, 2023
Merged

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Dec 5, 2023

  • scripts(ps1): fix command chaining
  • scripts(ps1): move to where it is needed
  • scripts(ps1): use name field to exactly match filename
  • scripts(ps1): test if script is run from repo root
  • scripts(ps1): add message for downloading
  • scripts(ps1): replace broken expand-archive with ZipFile
  • scripts(ps1): use explicit output filename
  • scripts(ps1): output download info

Closes #839

Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - merging! I'm not a PowerShell user, but this seems sane. I guess it broke due to a PowerShell version update. I haven't seen a failure in the fetch-configlet CI job - but maybe the PowerShell version there is still good, or it hasn't been run recently enough.

I'll try to add PSScriptAnalyzer to the configlet CI, especially since we already have shellcheck for other scripts.

@ee7 ee7 merged commit 2630458 into main Dec 15, 2023
19 checks passed
@ee7 ee7 deleted the fix-ps1-script branch December 15, 2023 10:54
@ee7 ee7 changed the title Fix powershell script fetch-configlet.ps1: fix for newer PowerShell versions Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetch-configlet.ps1: "Cannot validate argument" error
2 participants