lint(track_config): disallow difficulty 0 #447

ee7 · 2021-10-22T07:43:25Z

We want this if exercism/docs#290 is merged.

Confirming that this is the only place we use difficulty:

$ git grep --heading 'difficulty'
src/lint/track_config.nim
95:      hasInteger(data, "difficulty", path, context, allowed = 1..10),
279:    # difficulty*: int

See exercism/docs#290 and exercism/configlet#447.

Previously, a difficulty value of 0 was allowed, and `configlet lint` checked that each difficulty value was in the range from 0 to 10 inclusive. However, a difficulty of 0 is now disallowed. Typically, exercises with a difficulty value of 0 were deprecated exercises, but these still appear on the website for users who started them before they were deprecated, and so they should still have a difficulty level as normal. With this commit, we change the difficulty of our one deprecated exercise (`binary`) to an allowed value. See: - exercism/docs#290 - exercism/configlet#447

#2048) See exercism/docs#290 and exercism/configlet#447.

#1382) See exercism/docs#290 and exercism/configlet#447.

#1257) See exercism/docs#290 and exercism/configlet#447.

#1009) See exercism/docs#290 and exercism/configlet#447.

#323) See exercism/docs#290 and exercism/configlet#447.

#499) See exercism/docs#290 and exercism/configlet#447.

#437) See exercism/docs#290 and exercism/configlet#447.

#1697) See exercism/docs#290 and exercism/configlet#447.

#1008) See exercism/docs#290 and exercism/configlet#447.

See exercism/docs#290 and exercism/configlet#447.

#429) See exercism/docs#290 and exercism/configlet#447.

lint(track_config): disallow difficulty 0

3f36418

ee7 requested a review from ErikSchierboom as a code owner October 22, 2021 07:43

ErikSchierboom approved these changes Oct 22, 2021

View reviewed changes

ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this pull request Oct 22, 2021

Set difficulty to for exercises which difficulty is currently .

9d45c9e

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty to ErikSchierboom/csharp#37

Closed

ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

28ab938

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 ErikSchierboom/csharp#38

Closed

ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

c260178

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

0573178

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 ErikSchierboom/csharp#39

Closed

ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

6f5f282

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/csharp#1697

Merged

ErikSchierboom added a commit to ErikSchierboom/csharp that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

b594ba6

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/fsharp that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

a5724cb

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/fsharp#1008

Merged

ErikSchierboom added a commit to ErikSchierboom/go that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

d27909d

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/go#1883

Merged

ErikSchierboom added a commit to ErikSchierboom/haskell that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

fbc65fb

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/haskell#1009

Merged

ErikSchierboom added a commit to ErikSchierboom/java that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

f8469bb

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/java#2048

Merged

ErikSchierboom added a commit to ErikSchierboom/javascript that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

771975e

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/javascript#1460

Merged

ErikSchierboom added a commit to ErikSchierboom/kotlin that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

84b97a5

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/kotlin#511

Merged

ErikSchierboom added a commit to ErikSchierboom/lfe that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

8966085

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/lfe#145

Merged

ErikSchierboom added a commit to ErikSchierboom/lua that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

9be6a42

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/lua#323

Merged

ErikSchierboom added a commit to ErikSchierboom/nim that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

92a9c98

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/lfe that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

0b6ba51

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/lua that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

d0e386b

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/nim that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

7156a10

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/ocaml that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

66afb12

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/perl5 that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

d415c7d

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/perl5#437

Merged

ErikSchierboom added a commit to ErikSchierboom/racket that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

3e78482

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/racket#213

Merged

ErikSchierboom added a commit to ErikSchierboom/raku that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

14a4c59

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom mentioned this pull request Oct 22, 2021

🤖 Change difficulty 0 to 1 exercism/raku#499

Merged

ErikSchierboom added a commit to ErikSchierboom/red that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

28b4bce

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/ruby that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

29bb9cc

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/rust that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

6101445

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/scala that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

84f8097

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/sml that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

02d19e9

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/swift that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0.

96522db

See exercism/docs#290 and exercism/configlet#447.

mirkoperillo pushed a commit to exercism/java that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0. (

65faa74

#2048) See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to exercism/rust that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0. (

d1fbdca

#1382) See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to exercism/ruby that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0. (

ab35eb6

#1257) See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to exercism/haskell that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0. (

403c921

#1009) See exercism/docs#290 and exercism/configlet#447.

ee7 merged commit 36a07d8 into exercism:main Oct 22, 2021

ee7 deleted the lint-track-config-disallow-difficulty-0 branch October 22, 2021 11:35

imolein pushed a commit to exercism/lua that referenced this pull request Oct 22, 2021

Set difficulty to 1 for exercises which difficulty is currently 0. (

6378033

#323) See exercism/docs#290 and exercism/configlet#447.

m-dango pushed a commit to exercism/raku that referenced this pull request Oct 23, 2021

Set difficulty to 1 for exercises which difficulty is currently 0. (

3c316f6

#499) See exercism/docs#290 and exercism/configlet#447.

m-dango pushed a commit to exercism/perl5 that referenced this pull request Oct 23, 2021

Set difficulty to 1 for exercises which difficulty is currently 0. (

bc28fbc

#437) See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to exercism/csharp that referenced this pull request Oct 25, 2021

Set difficulty to 1 for exercises which difficulty is currently 0. (

01a707b

#1697) See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to exercism/fsharp that referenced this pull request Oct 26, 2021

Set difficulty to 1 for exercises which difficulty is currently 0. (

354d446

#1008) See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to ErikSchierboom/ocaml that referenced this pull request Mar 12, 2022

Set difficulty to 1 for exercises which difficulty is currently 0.

668a674

See exercism/docs#290 and exercism/configlet#447.

ErikSchierboom added a commit to exercism/ocaml that referenced this pull request Mar 15, 2022

Set difficulty to 1 for exercises which difficulty is currently 0. (

9810519

#429) See exercism/docs#290 and exercism/configlet#447.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lint(track_config): disallow difficulty 0 #447

lint(track_config): disallow difficulty 0 #447

ee7 commented Oct 22, 2021

lint(track_config): disallow difficulty 0 #447

lint(track_config): disallow difficulty 0 #447

Conversation

ee7 commented Oct 22, 2021