Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Change difficulty 0 to 1 #1009

Merged

Conversation

ErikSchierboom
Copy link
Member

Set difficulty to 1 for exercises which difficulty is currently 0.
See exercism/docs#290 and exercism/configlet#447.

Please feel free to update the difficulty to another value (the allowed range is 1-10) if you think that makes more sense.

@ErikSchierboom ErikSchierboom added v3-migration 🤖 Preparing for Exercism v3 x:size/tiny Tiny amount of work labels Oct 22, 2021
@petertseng
Copy link
Member

If difficulty is meaningless for deprecated exercises, the attribute should just be deleted for them, and configlet should not expect it to be present.

If difficulty is meaningful for deprecated exercises, the difficulty of the exercises should be restored to their pre-deprecation values.

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the difficulty of the exercises should be restored to their pre-deprecation values.

What I have asked is impossible. The deprecation of these excercises predates the concept of a difficulty value for exercises. In that case, take no further action and merge as-is.

@ErikSchierboom
Copy link
Member Author

If difficulty is meaningful for deprecated exercises, the difficulty of the exercises should be restored to their pre-deprecation values.

It is indeed meaningful, as deprecated exercises were once active and any student that started the exercise before it was deprecated will still have access to it even after it was deprecated.

@ErikSchierboom ErikSchierboom merged commit 403c921 into exercism:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3-migration 🤖 Preparing for Exercism v3 x:size/tiny Tiny amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants