generate: make interface consistent with sync and fmt #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee7
force-pushed
the
generate-consistent-interface
branch
from
4ee5d51
to
8a64701
Compare
This was referenced Jul 1, 2022
Merged
ee7
force-pushed
the
generate-consistent-interface
branch
from
8a64701
to
5e233c7
Compare
ee7
commented
Aug 17, 2023
This was referenced Aug 18, 2023
Merged
ErikSchierboom
force-pushed
the
generate-consistent-interface
branch
from
5e233c7
to
0706be0
Compare
We must still at least: - alter `generate.nim` - update the tests accordingly Refs: 334 Refs: 542
ErikSchierboom
force-pushed
the
generate-consistent-interface
branch
2 times, most recently
from
27d35b4
to
bca2698
Compare
ErikSchierboom
force-pushed
the
generate-consistent-interface
branch
from
bca2698
to
f48ecf4
Compare
|
Due to limited time, I've not added new tests but only fixed the existing ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To-do:
generate.nimnon-destructive by default, and support-u,-yand-egenerateCloses: #334
Closes: #542