Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: 4.0.0-beta.5 #621

Merged
merged 1 commit into from
Jul 1, 2022
Merged

release: 4.0.0-beta.5 #621

merged 1 commit into from
Jul 1, 2022

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Jun 17, 2022 •
edited
Loading

Let's create a release for these user-facing changes:

  • ef65ef9 generate: demote headings, and group link reference definitions (#620)
  • 96b7d37 sync: remove "Updating tests..." message (#623)
  • 3f4193f sync(tests): improve error for invalid TOML (#614)

And these other changes:

@ee7 ee7 requested a review from ErikSchierboom as a code owner June 17, 2022 16:13
@ee7 ee7 marked this pull request as draft June 17, 2022 16:13
ErikSchierboom
ErikSchierboom approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦜

Getting closer to that major release! 😉

@ee7
Copy link
Member Author

ee7 commented Jul 1, 2022 •
edited
Loading

@ErikSchierboom happy for me to release after I merge #620?

It would be the first release with a (hopefully) sufficiently functional configlet generate, without waiting for the work on libcmark or consistent support for -u, -y, and -e. I was originally hoping to get #619 in this release, but #620 and its upcoming follow-ups ended up being much more time consuming than expected.

@ee7 ee7 marked this pull request as ready for review July 1, 2022 22:56
@ee7 ee7 merged commit 6ae8274 into main Jul 1, 2022
@ee7 ee7 deleted the release-4.0.0-beta.5 branch July 1, 2022 22:57
glennj pushed a commit to glennj/exercism-configlet that referenced this pull request Jul 8, 2022
@ee7 @glennj
release: 4.0.0-beta.5 (exercism#621)
09adbc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ee7 @ErikSchierboom