Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] replace SetupProvisioningProfile #317

Merged
merged 3 commits into from
Apr 9, 2021

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Apr 8, 2021

Checklist

Why

Replace old SetupProvisioningProfile with new SetupProvisioningProfile. Also removed classes that are no longer used due to the replacement.

Test Plan

Manually tested this still works

quins-MacBook-Pro:test53 quin$ ~/Documents/eas-cli/packages/eas-cli/bin/run build
✔ Build for platforms › iOS
✔ Linked to project @quinlanj/test53

Warning! Your git working tree is dirty.
This operation needs to be run on a clean working tree, please commit all your changes before proceeding.
✔ Commit changes to git? … yes
✔ Commit message: … sdf
✔ iOS credentials not found, generate now? … yes
If you provide your Apple account credentials we will be able to generate all necessary build credentials and fully validate them.
This is optional, but without Apple account access you will need to provide all the values manually and we can only run minimal validation on them.
✔ Do you want to log in to your Apple account? … yes

› Log in to your Apple Developer account to continue
✔ Apple ID: … quin@expo.io
› Restoring session /Users/quin/.app-store/auth/quin@expo.io/cookie
✔ Select a Team › quinlan jung - Individual ([redacted])
› Provider quinlan jung ([redacted])
✔ Switched to provider: quinlan jung ([redacted])
✔ Logged in Local session
✔ Bundle identifier registered foo.bar.quintest
✔ Synced capabilities
✔ Fetched Apple distribution certificates
✔ Reuse this distribution certificate?
Cert ID: 28A8845Y3T, Serial number: 14C1F08D9F4356896EF6093627D9BA8A, Team ID: [redacted]
    Created: 21 hours ago, Updated: 21 hours ago,
    Expires: Thu, 07 Apr 2022 17:40:24 PDT
    📲 Used by: @quinlanj/test52 … yes
Using distribution certificate with serial number 14C1F08D9F4356896EF6093627D9BA8A
✔ Generate a new Apple Provisioning Profile? … yes
✔ Created Apple provisioning profile
✔ Created provisioning profile

Project Credentials Configuration:
  Project: @quinlanj/test53, bundle identifier: foo.bar.quintest
    Provisioning profile (ID: 9F4ASXT9YN)
    Apple Team ID: [redacted],  Apple Team Name: ---------

  Distribution Certificate - Certificate ID: 28A8845Y3T
    Apple Team ID: [redacted],  Apple Team Name: ---------

All credentials are ready to build @quinlanj/test53 (foo.bar.quintest)

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Size Change: -1.6 kB (0%)

Total Size: 32.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 32.9 MB -1.6 kB (0%)

compressed-size-action

Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@quinlanj quinlanj merged commit 91500d0 into main Apr 9, 2021
@quinlanj quinlanj deleted the @quin/replaceSetupProvProf branch April 9, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants