Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] replace SetupProvisioningProfile #317

Merged
merged 3 commits into from
Apr 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ This is the log of notable changes to EAS CLI and related packages.

### 🧹 Chores

- Replace Credentials REST API calls with GraphQL counterparts, also improved DX. ([#293](https://github.com/expo/eas-cli/pull/293), [#299](https://github.com/expo/eas-cli/pull/299), [#301](https://github.com/expo/eas-cli/pull/301), [#317](https://github.com/expo/eas-cli/pull/317) by [@quinlanj](https://github.com/quinlanj))

## [0.8.1](https://github.com/expo/eas-cli/releases/tag/v0.8.1) - 2021-04-06

### 🐛 Bug fixes
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import { isCredentialsMap, readIosCredentialsAsync } from '../../credentialsJson
import { AppLookupParams, IosAppCredentials, IosDistCredentials } from '../credentials';
import { displayProjectCredentials } from '../utils/printCredentials';
import { readAppleTeam } from '../utils/provisioningProfile';
import { SetupProvisioningProfile } from './SetupProvisioningProfile';
import { SetupAdhocProvisioningProfile } from './new/SetupAdhocProvisioningProfile';
import { SetupProvisioningProfile } from './new/SetupProvisioningProfile';

type AppCredentialsAndDistCert = {
appCredentials: IosAppCredentials;
Expand All @@ -32,11 +32,11 @@ export class SetupBuildCredentials implements Action {

let iosAppBuildCredentials: IosAppBuildCredentialsFragment | null = null;
try {
const account = findAccountByName(ctx.user.accounts, this.app.accountName);
if (!account) {
throw new Error(`You do not have access to the ${this.app.accountName} account`);
}
if (this.distribution === 'internal') {
const account = findAccountByName(ctx.user.accounts, this.app.accountName);
if (!account) {
throw new Error(`You do not have access to the ${this.app.accountName} account`);
}
const action = new SetupAdhocProvisioningProfile({
account,
projectName: this.app.projectName,
Expand All @@ -45,7 +45,12 @@ export class SetupBuildCredentials implements Action {
await manager.runActionAsync(action);
iosAppBuildCredentials = action.iosAppBuildCredentials;
} else {
await manager.runActionAsync(new SetupProvisioningProfile(this.app));
const setupProvisioningProfileAction = new SetupProvisioningProfile({
account,
projectName: this.app.projectName,
bundleIdentifier: this.app.bundleIdentifier,
});
await setupProvisioningProfileAction.runAsync(manager, ctx);
}
} catch (error) {
Log.error('Failed to setup credentials.');
Expand Down

This file was deleted.

This file was deleted.