Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK45 #371

Merged
Merged

Conversation

kbrandwijk
Copy link
Contributor

@kbrandwijk kbrandwijk commented May 10, 2022

  • Ran expo upgrade in all projects
  • Updated 3 projects using expo-app-loading to not use it anymore, as it is now deprecated

Ran a few, didn't run them all. What level of manual checking do we usually do on these after an SDK release?

@linear
Copy link

linear bot commented May 10, 2022

@kbrandwijk kbrandwijk marked this pull request as ready for review May 10, 2022 23:34
@kbrandwijk kbrandwijk requested a review from EvanBacon May 10, 2022 23:34
@kbrandwijk
Copy link
Contributor Author

Hold on merging, will update all projects to 0.68.2

@kbrandwijk kbrandwijk marked this pull request as draft May 12, 2022 04:27
@EvanBacon
Copy link
Contributor

Generally we test the packages that use experimental functionality or features that wouldn't have been otherwise tested during QA. For example, native base is pretty reliable but react-three-fiber (which is more of a web library) may not run as expected.

@kbrandwijk kbrandwijk marked this pull request as ready for review May 24, 2022 22:33
@kbrandwijk
Copy link
Contributor Author

Decided we can do some additional checks and fixes on the individual basis, but it's worth more to at least have all of the examples on SDK 45 at this point.

@kbrandwijk kbrandwijk requested review from EvanBacon and removed request for EvanBacon May 24, 2022 22:34
Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's tough to review prs like this which just change deps - but if everything runs then i think it's good!

@kbrandwijk kbrandwijk merged commit b496646 into master May 27, 2022
@kbrandwijk kbrandwijk deleted the @kbrandwijk/eng-4923-upgrade-example-projects-to-sdk-45 branch May 27, 2022 23:09
@keith-kurak keith-kurak mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants