-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to SDK 46 #385
Upgrade to SDK 46 #385
Conversation
086f9c9
to
d918ba0
Compare
985a4fc
to
4b7d878
Compare
blank/README.md
Outdated
@@ -19,18 +19,17 @@ | |||
|
|||
- Install packages with `yarn` or `npm install`. | |||
- If you have native iOS code run `npx pod-install` | |||
- Run `yarn start` to start the bundler. | |||
- Run `npx expo start` to start the bundler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't matter but we inject the start script when the user bootstraps with CRNA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to know! Some examples were one way, some the other, so was trying to pick one and apply it across the board. Knowing that it's always there, makes sense change it to yarn/ npm, which seems more consistent with other tool's templates.
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
What
expo upgrade
on all projects at once and writes the command output to a non-committed folder for review (can also runexpo doctor --fix-dependencies
on all projects, for those times where the SDK's RN version is updated mid-PR 😄 ).expo start
across the board due to several package.json files containing noscripts
.eject
.Spot-checking results
✅ with-yarn-workspaces
expo-yarn-workspaces
, added separate script for watching packages (previously ran automatically after runningyarn
)✅ with-electron
yarn expo-electron customize
and addcontextIsolation: false
to index.js, so updated accordingly. Wondering if this should either be reflected in docs or if@expo/electron-adapter
can be/ should be updated to do this by default.✅ with-gatsby
gatsby
version at 2.x, as plugin isn't compatible with 3 or 4.✅ with-three / with-react-three-fiber
expo-three
, plus a post 0.127.0 version ofthree
, which fixes [Unhandled promise rejection: TypeError: null is not an object (evaluating 'gl.canvas.width')] expo-three#202Updates.reloadAsync()
fails silently with "You cannot reload when expo-updates is not enabled" on iOS on Expo Go (not a problem with example, issue opened)@expo/next-adapter
/nextjs
dependencies on the same version; homepage url hangs indefinitely if I runyarn expo-next
from scratch on latest adapter version (which installs next 12.x, which uses requires webpack 5, while the adapter uses 4), I get a fatal babel error if I install the required peer-dependency version of next (^11, which can use Webpack 4, but doesn't by default).✅ with-moti
✅ with-typescript
✅ with-tab-navigation
✅ with-drawer-navigation
@babel/plugin-proposal-export-namespace-from
onexport * as default from './Animated';
software-mansion/react-native-reanimated#3410