Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SDK 46 #385

Merged

Conversation

keith-kurak
Copy link
Contributor

@keith-kurak keith-kurak commented Aug 10, 2022

What

  • Updated all examples to SDK 46
  • Checked for removed libraries in examples per release blog (none found)
  • Added a quick-and-dirty upgrade-dependencies.sh script that runs expo upgrade on all projects at once and writes the command output to a non-committed folder for review (can also run expo doctor --fix-dependencies on all projects, for those times where the SDK's RN version is updated mid-PR 😄 ).
  • Spot-checked several projects based on a) if they failed to automatically update via the aforementioned script, b) were mentioned specifically during the previous update (SDK45 #371), or c) otherwise seemed interesting or notable.
  • In some cases, updated additional dependencies and/ or readme's to reflect my experiences getting the spot-checked examples up-and-running
  • Made readme's consistently refer to expo start across the board due to several package.json files containing no scripts.
  • Remove references to global CLI and eject.

Spot-checking results

✅ with-yarn-workspaces

  • updated to match the instructions in the Expo Monorepos Guide
  • tweaked the npm scripts to account for removal of expo-yarn-workspaces, added separate script for watching packages (previously ran automatically after running yarn)

✅ with-electron

  • I've tried adding electron at least three times in recent months, and it never works unless I run yarn expo-electron customize and add contextIsolation: false to index.js, so updated accordingly. Wondering if this should either be reflected in docs or if @expo/electron-adapter can be/ should be updated to do this by default.

✅ with-gatsby

  • Kept gatsby version at 2.x, as plugin isn't compatible with 3 or 4.

✅ with-three / with-react-three-fiber

⚠️ with-splash-screen

  • Works on Android, but Updates.reloadAsync() fails silently with "You cannot reload when expo-updates is not enabled" on iOS on Expo Go (not a problem with example, issue opened)

⚠️ with-nextjs

  • Works if I leave @expo/next-adapter/ nextjs dependencies on the same version; homepage url hangs indefinitely if I run yarn expo-next from scratch on latest adapter version (which installs next 12.x, which uses requires webpack 5, while the adapter uses 4), I get a fatal babel error if I install the required peer-dependency version of next (^11, which can use Webpack 4, but doesn't by default).

✅ with-moti

✅ with-typescript

✅ with-tab-navigation

✅ with-drawer-navigation

@keith-kurak keith-kurak marked this pull request as ready for review August 10, 2022 21:48
@keith-kurak keith-kurak force-pushed the keith/eng-5945-upgrade-examples-to-sdk-46 branch from 086f9c9 to d918ba0 Compare August 10, 2022 21:58
@keith-kurak keith-kurak force-pushed the keith/eng-5945-upgrade-examples-to-sdk-46 branch from 985a4fc to 4b7d878 Compare August 11, 2022 21:13
blank/README.md Outdated
@@ -19,18 +19,17 @@

- Install packages with `yarn` or `npm install`.
- If you have native iOS code run `npx pod-install`
- Run `yarn start` to start the bundler.
- Run `npx expo start` to start the bundler.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't matter but we inject the start script when the user bootstraps with CRNA.

Copy link
Contributor Author

@keith-kurak keith-kurak Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know! Some examples were one way, some the other, so was trying to pick one and apply it across the board. Knowing that it's always there, makes sense change it to yarn/ npm, which seems more consistent with other tool's templates.

blank/README.md Outdated Show resolved Hide resolved
blank/README.md Outdated Show resolved Hide resolved
with-electron/README.md Outdated Show resolved Hide resolved
with-maps/README.md Outdated Show resolved Hide resolved
with-maps/README.md Outdated Show resolved Hide resolved
with-moti/README.md Outdated Show resolved Hide resolved
with-moti/README.md Outdated Show resolved Hide resolved
with-yarn-workspaces/README.md Outdated Show resolved Hide resolved
keith-kurak and others added 6 commits August 15, 2022 06:18
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
keith-kurak and others added 3 commits August 15, 2022 06:18
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
Co-authored-by: Kim Brandwijk <kim.brandwijk@gmail.com>
@keith-kurak keith-kurak requested a review from brentvatne August 15, 2022 18:57
@keith-kurak keith-kurak merged commit 24e3f53 into expo:master Aug 18, 2022
@keith-kurak keith-kurak deleted the keith/eng-5945-upgrade-examples-to-sdk-46 branch August 18, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Unhandled promise rejection: TypeError: null is not an object (evaluating 'gl.canvas.width')]
3 participants