-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to SDK 46 #385
Merged
keith-kurak
merged 25 commits into
expo:master
from
keith-kurak:keith/eng-5945-upgrade-examples-to-sdk-46
Aug 18, 2022
Merged
Upgrade to SDK 46 #385
Changes from 16 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
be38369
chore: run expo upgrade on all projects
keith-kurak a71b33d
update with-yarn-workspaces to use latest monorepo doc
keith-kurak 0430edd
update with-gatsby dependencies to fix errors
keith-kurak 6cbfa48
fix 'require not defined' error on with-electron
keith-kurak d0292b0
with-three updated, now working
keith-kurak 2cfc41d
with-react-three-fiber other deps updated, working
keith-kurak 0fdfad4
update with-splash-screen for clarity
keith-kurak 461cd93
upgrade all examples to react-native 0.69.4
keith-kurak 5dd5e68
clean up with-moti
keith-kurak 5f7bb0e
cleaned up react-navigation examples
keith-kurak 8eae40b
cleaned up refs to potentially missing NPM scripts
keith-kurak 29e3a87
renamed upgrade script for clarity
keith-kurak 09aaea1
fix missed update to react-native 0.69.4
keith-kurak 9236b70
Fix inaccurate script output
keith-kurak d918ba0
remove inaccurate warning
keith-kurak 4b7d878
remove refs to global CLI/ ejecting
keith-kurak f6b4d68
Update blank/README.md
keith-kurak 48c6fba
Update blank/README.md
keith-kurak e63d920
Update with-maps/README.md
keith-kurak 98d4172
Update with-maps/README.md
keith-kurak 6942cfb
Update with-moti/README.md
keith-kurak 014cff5
Update with-yarn-workspaces/README.md
keith-kurak 9c04a4f
Update with-electron/README.md
keith-kurak c542896
Update with-moti/README.md
keith-kurak f02c100
consistent directions for starting projects, rm cli refs
keith-kurak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,4 +27,7 @@ with-nextjs/out | |
*/backend/.env | ||
|
||
.DS_Store | ||
report.html | ||
report.html | ||
|
||
# Maintenance logs | ||
.sdk-upgrade-logs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"expo": { | ||
"name": "blank", | ||
"slug": "blank", | ||
"version": "1.0.0", | ||
"platforms": [ | ||
"ios", | ||
"android", | ||
"web" | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
{ | ||
"dependencies": { | ||
"expo": "^45.0.0", | ||
"react": "17.0.2", | ||
"react-dom": "17.0.2", | ||
"react-native": "0.68.2", | ||
"react-native-web": "0.17.7" | ||
"expo": "^46.0.0", | ||
"react": "18.0.0", | ||
"react-dom": "18.0.0", | ||
"react-native": "0.69.4", | ||
"react-native-web": "~0.18.7" | ||
}, | ||
"devDependencies": { | ||
"@babel/core": "^7.12.9" | ||
"@babel/core": "^7.18.6" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
#!/usr/bin/env bash | ||
|
||
if [ "$1" == "" ] || [ "$1" == "--help" ]; then | ||
echo "Available flags:" | ||
echo "--help" | ||
echo "--run-expo-upgrade - run yarn and expo-cli upgrade to update to latest SDK on all examples" | ||
echo "--run-fix-dependencies - run npx expo install --fix on all repos" | ||
exit 0 | ||
fi | ||
|
||
if [ "$1" == "--run-expo-upgrade" ]; then | ||
echo "Upgrading all projects to the latest SDK..." | ||
echo "For each example, this will run `yarn` and then run `expo-cli upgrade`, accepting all defaults." | ||
echo "Upgrade logs will be written to .sdk-upgrade-logs." | ||
|
||
mkdir ./.sdk-upgrade-logs | ||
for d in */ ; do | ||
DIRNAME=${d%/} | ||
echo "Upgrading $DIRNAME..." | ||
echo "β’ Run yarn" | ||
(cd $DIRNAME && yarn --silent) # If yarn fails spectacularly, we'll see evidence in the logs for expo upgrade | ||
echo "β’ Run expo upgrade" | ||
(cd $DIRNAME && echo y | expo-cli upgrade > ../.sdk-upgrade-logs/$DIRNAME.txt) | ||
done | ||
|
||
# yarn workspaces has example(s) inside of app folder | ||
echo "β’ Run expo upgrade on apps inside with-yarn-workspaces" | ||
mkdir ./.sdk-upgrade-logs/with-yarn-workspaces | ||
for d in with-yarn-workspaces/apps/*/ ; do | ||
(cd $DIRNAME && echo y | expo-cli upgrade > ../.sdk-upgrade-logs/$DIRNAME.txt) | ||
done | ||
|
||
echo "Upgrades complete! Check .sdk-upgrade-logs for results. Be sure to correct any errors or warnings." | ||
exit 0 | ||
fi | ||
|
||
if [ "$1" == "--run-fix-dependencies" ]; then | ||
echo "Fixing dependencies on all examples..." | ||
|
||
mkdir ./.sdk-upgrade-logs | ||
for d in */ ; do | ||
DIRNAME=${d%/} | ||
echo "Fixing dependencies on $DIRNAME..." | ||
(cd $DIRNAME && npx expo install --fix) | ||
done | ||
|
||
echo "Fixing dependencies on apps inside with-yarn-workspaces..." | ||
mkdir ./.sdk-upgrade-logs/with-yarn-workspaces | ||
for d in with-yarn-workspaces/apps/*/ ; do | ||
(cd $DIRNAME && npx expo install --fix) | ||
done | ||
|
||
echo "Dependency fixes complete!" | ||
exit 0 | ||
fi | ||
|
||
echo "Error: flag not recognized" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,15 @@ | ||
{ | ||
"dependencies": { | ||
"expo": "^45.0.0", | ||
"expo-auth-session": "~3.6.0", | ||
"expo-random": "~12.2.0", | ||
"expo": "^46.0.0", | ||
"expo-auth-session": "~3.7.1", | ||
"expo-random": "~12.3.0", | ||
"jwt-decode": "2.2.0", | ||
"react": "17.0.2", | ||
"react-dom": "17.0.2", | ||
"react-native": "0.68.2", | ||
"react-native-web": "0.17.7" | ||
"react": "18.0.0", | ||
"react-dom": "18.0.0", | ||
"react-native": "0.69.4", | ||
"react-native-web": "~0.18.7" | ||
}, | ||
"devDependencies": { | ||
"@babel/core": "^7.12.9" | ||
"@babel/core": "^7.18.6" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
{ | ||
"dependencies": { | ||
"expo": "^45.0.0", | ||
"expo-camera": "~12.2.0", | ||
"react": "17.0.2", | ||
"react-dom": "17.0.2", | ||
"react-native": "0.68.2", | ||
"react-native-web": "0.17.7" | ||
"expo": "^46.0.0", | ||
"expo-camera": "~12.3.0", | ||
"react": "18.0.0", | ||
"react-dom": "18.0.0", | ||
"react-native": "0.69.4", | ||
"react-native-web": "~0.18.7" | ||
}, | ||
"devDependencies": { | ||
"@babel/core": "^7.12.9" | ||
"@babel/core": "^7.18.6" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
{ | ||
"dependencies": { | ||
"expo": "^45.0.0", | ||
"expo-font": "~10.1.0", | ||
"expo-splash-screen": "~0.15.1", | ||
"react": "17.0.2", | ||
"react-dom": "17.0.2", | ||
"react-native": "0.68.2", | ||
"react-native-web": "0.17.7" | ||
"expo": "^46.0.0", | ||
"expo-font": "~10.2.0", | ||
"expo-splash-screen": "~0.16.1", | ||
"react": "18.0.0", | ||
"react-dom": "18.0.0", | ||
"react-native": "0.69.4", | ||
"react-native-web": "~0.18.7" | ||
}, | ||
"devDependencies": { | ||
"@babel/core": "^7.12.9" | ||
"@babel/core": "^7.18.6" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't matter but we inject the start script when the user bootstraps with CRNA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to know! Some examples were one way, some the other, so was trying to pick one and apply it across the board. Knowing that it's always there, makes sense change it to yarn/ npm, which seems more consistent with other tool's templates.