[menu-bar] Refactor deep-link routes to comply with the URL spec #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/refactor-deeplinks
branch
from
42a0b9d
to
6e4e59b
Compare
alanjhughes
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As Cedric pointed out on expo/snack#548 (comment) our current deep-link format implementation does not comply with the URL spec.
How
This PR refactors our deep-link routes to use the
urlquery parameter to specify URLs instead of just appending them directly to the path. In order to maintain backward compatibility with the formats that already live on our website this PR just changes the/routedeep links.This also add unit tests for all the currently supported types of URL
Test Plan
yarn test