chore(website): Update Orbit deep link route #548
Conversation
website/src/client/utils/orbit.ts
Outdated
| @@ -66,14 +66,15 @@ export function useOrbit() { | |||
| return; | |||
| } | |||
|
|
|||
| const deeplink = `expo-orbit://snack/${experienceURL.replace('exp://', '')}`; | |||
There was a problem hiding this comment.
I think this might actually break the URL spec. What you'll get is something like this:
expo-orbit://snack/u.expo.dev/XXX?snack=YYY&snack-channel=ZZZ...
I don't think the u.expo.dev is allowed as path name characters.
There was a problem hiding this comment.
A good example here is Cloudflare, no idea wtf is going on here but it seems I broke their implementation of matching CNAME records with this type of URL https://expo-snack.app/u.expo.dev/xxx?snack=yyy
And even the actual URL breaks due to some SSL cypher issues https://xxx.50.expo-snack.app/u.expo.dev/xxx?snack=yyy
There was a problem hiding this comment.
That being said, if it works 🤷
There was a problem hiding this comment.
Ohh I see, we should probably try to stay in the URL spec. What if we used expo-orbit://snack/?url=exp://u.expo.dev/XXX?snack=YYY&snack-channel=ZZZ... instead?
There was a problem hiding this comment.
I've updated this PR and Orbit to support the following format expo-orbit://snack/?url=exp://u.expo.dev/XXX?snack=YYY&snack-channel=ZZZ
Why
With the new
experienceURLformat Orbit can no longer distinguish an Expo Update from an Snack just by checking the URL, because of that we should use the/snackroute which is specific for snacksCloses ENG-11059
How
Update Orbit deep link route to use
/snackTest Plan
Run snack locally and launch Orbit from the button
Screen.Recording.2024-01-26.at.11.34.46.mov