Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting: Typescript files not highlighted #2005

Closed
pmiossec opened this issue Jan 11, 2024 · 4 comments · Fixed by #2160
Closed

Syntax highlighting: Typescript files not highlighted #2005

pmiossec opened this issue Jan 11, 2024 · 4 comments · Fixed by #2160
Labels
bug Something isn't working feature-request good first issue Good for newcomers
Milestone

Comments

@pmiossec
Copy link

Describe the bug

Files with .ts and .tsx files are supported.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Files' tab
  2. Select a typescript file with .ts extension
  3. See that there is no syntax highlighting (but working with other type of files)

Expected behavior

a typescript file with .ts extension is highlighted.

Context (please complete the following information):

  • OS/Distro + Version: Windows 11
  • GitUI Version: 0.24.3

Additional context

Sorry, I know that it is maybe a https://github.com/trishume/syntect/ issue but as not being a rust developer, I won't be able to manage it rightfully.

@pmiossec pmiossec added the bug Something isn't working label Jan 11, 2024
@pmiossec
Copy link
Author

Another tool that use the same version is working well ( https://github.com/dandavison/delta/blob/main/Cargo.toml#L41 ). So I don't know...

@extrawurst
Copy link
Owner

seems to be a syntect limitation: trishume/syntect#447

@Aleksanaa
Copy link

seems to be a syntect limitation: trishume/syntect#447

But syntect isn't going to adding even more language support, and others can be added by introducing two-face (trishume/syntect#523 (comment))

@extrawurst
Copy link
Owner

Good find!

@extrawurst extrawurst added this to the v0.26 milestone Mar 27, 2024
extrawurst pushed a commit that referenced this issue Mar 27, 2024
closes #2005

Co-authored-by: MHS <mhs@histolution.com>
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
closes extrawurst#2005

Co-authored-by: MHS <mhs@histolution.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature-request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants