syntect additional file type support #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you run a quick comparison in generated binary size by this? both in release and debug |
master branch (without two-face)debug -> 17.9 MB syntect branch (with two-face)debug -> 18.2 MB |
|
not great not terrible :D |
extrawurst
reviewed
Mar 27, 2024
extrawurst
force-pushed
the
2005-syntect-additional-file
branch
from
859729b to
7172bda
Compare
|
Thank you! |
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this pull request
Jun 4, 2024
closes extrawurst#2005 Co-authored-by: MHS <mhs@histolution.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2005.
It changes the following:
I followed the checklist:
make checkwithout errors