Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md and Requirements.txt #246

Merged
merged 7 commits into from
Aug 27, 2023
Merged

Conversation

mofosyne
Copy link
Contributor

@mofosyne mofosyne commented Aug 2, 2023

Add to readme information about mathplotlib

@mofosyne
Copy link
Contributor Author

mofosyne commented Aug 2, 2023

This change was based on my experience in this issue ticket #245

This readme update doesn't address the udev rule issue encountered in it as I'm not sure what the best way to explain why it doesn't work on a fresh install and that you have to add extra udev rules to make this work.

@mofosyne
Copy link
Contributor Author

mofosyne commented Aug 4, 2023

Btw... I've been wondering how to get a console log of this extension so I can better understand what it's thinking.

Also bit of a python noob so would be good to hear recommendation how to hook up a debugger to this.

@t0b3
Copy link
Collaborator

t0b3 commented Aug 11, 2023

Btw... I've been wondering how to get a console log of this extension so I can better understand what it's thinking.

Also bit of a python noob so would be good to hear recommendation how to hook up a debugger to this.

Simply run python sendto_silhouette.py --help or copy the specific command from any of your log files.
You will get some output on cmdline and even more in the log file. Also consider --logfile /tmp/PATH_OF_YOUR_CHOICE_TO_LOGFILE

@t0b3
Copy link
Collaborator

t0b3 commented Aug 11, 2023

Add to readme information about matplotlib

Thank you for your valuable contribution. Dependencies may change every now and then. (i.e. Inscape 1.4 will require tinycss2) To avoid duplication and sync' efforts I'd rather prefer pip install -r requirements.txt. This also helps keeping instructions more platform agnostic (except for GTK and matplotlib which are better managed by the distro). Can you update this PR accordingly?

BTW: And at the same time I'd like to merge the two Ubuntu parts keeping the inkscape:stable repo instruction with the advantage of using the latest version. (currently 1.3)

@mofosyne
Copy link
Contributor Author

Simply run python sendto_silhouette.py --help or copy the specific command from any of your log files.
You will get some output on cmdline and even more in the log file. Also consider --logfile /tmp/PATH_OF_YOUR_CHOICE_TO_LOGFILE

That would require me to run that script outside of inkscape? Might be a bit clunky.

I think what would be ideal is to set /tmp/inkscape-silhouette.log as the logfile by default. Not sure where to add that in however.

@mofosyne mofosyne changed the title Update README.md Update README.md and Requirements.txt Aug 13, 2023
@t0b3
Copy link
Collaborator

t0b3 commented Aug 13, 2023

Simply run python sendto_silhouette.py --help or copy the specific command from any of your log files.
You will get some output on cmdline and even more in the log file. Also consider --logfile /tmp/PATH_OF_YOUR_CHOICE_TO_LOGFILE

That would require me to run that script outside of inkscape? Might be a bit clunky.

I think what would be ideal is to set /tmp/inkscape-silhouette.log as the logfile by default. Not sure where to add that in however.

While there are use cases that invoke inkscape-silhouette.py directly, yet it's obvious this won't fit for all.

@mofosyne
Copy link
Contributor Author

mofosyne commented Aug 15, 2023

This readme change is ready to merge now

Regarding logging. Created a separate PR for it #249 "sento_silhouette: logfile param defaults to /tmp/inkscape-silhouette.log #249" so that it will pick a system default location for the logfile if empty and enabled.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@mofosyne mofosyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All minor changes made as requested

Copy link
Contributor Author

@mofosyne mofosyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@t0b3 t0b3 merged commit e8dd1ba into fablabnbg:main Aug 27, 2023
8 checks passed
@t0b3
Copy link
Collaborator

t0b3 commented Aug 27, 2023

@mofosyne THX for your contributions 🚀 that's what makes opensource so wonderful 😄

@mofosyne mofosyne deleted the patch-1 branch August 27, 2023 06:37
@mofosyne
Copy link
Contributor Author

Not a problem. I would say @miLORD1337 get a lot of credit for getting the ball rolling in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants