-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sento_silhouette: logfile param defaults to /tmp/inkscape-silhouette.log #249
Conversation
INX value works like this. 👍 |
Don't have windows or mac, but did some digging and this seems like the best approach. Added a function called get_default_logfile_path() to auto create a logfile path if non is given.
|
This is ready, just needs merging |
bf83ef8
to
cea4383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks elegant and seems to work on any platforms.
can you ensure it works on different platforms by introducing some kind of test?
i.e. check for self.default_logfile_path
and assert you can write a file to this path by appending another test?
2b95a2b
to
c05812b
Compare
Still trying to understand how inx works, but I think this would be how to add /tmp/inkscape-silhouette.log as the default logfile path.
This consistency if correct would make bug filing easier for newbies.