Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .NET 7.0 #3263

Closed
wants to merge 3 commits into from
Closed

Use .NET 7.0 #3263

wants to merge 3 commits into from

Conversation

ncave
Copy link
Collaborator

@ncave ncave commented Nov 9, 2022

  • Use .NET 7.0 for Fable.

@alfonsogarciacaro

Please note I'm not saying we should actually merge this PR.
This is more of an exploration to see if that resolves some .NET 7 issues that people are having.
Question: Is there a way to version the Fable dotnet tool separately for different major .NET releases?

@alfonsogarciacaro
Copy link
Member

We can try, although I'd like to avoid forcing users to update the sdk just to update Fable. But it would be interesting to see if there are actual performance improvements (although we've been disappointed in the past).

I am not aware of a way of using different sdk versions with dotnet tools. The only example I know of is Ionide and iirc they put different assemblies in the package and pick one based on the environment .

@alfonsogarciacaro
Copy link
Member

I think you can pass the dotnet exe location to Buildalyzer. So maybe we could pick dotnet 6 (if installed in the system) for project parsing .

@ncave
Copy link
Collaborator Author

ncave commented Nov 10, 2022

@alfonsogarciacaro

The only example I know of is Ionide and iirc they put different assemblies in the package and pick one based on the environment

Perhaps the problems are mainly when the Fable dotnet tool is globally installed.
I was wondering if Fable dotnet tool built with .NET 7.0 will run ok if only .NET 6.0 is installed.

@alfonsogarciacaro
Copy link
Member

I was wondering if Fable dotnet tool built with .NET 7.0 will run ok if only .NET 6.0 is installed.

I would have to check but my understanding is it won't work, although you can build with dotnet sdk 7 and target net6.0, but not sure if this will help with the project parsing.

See #3265 for an alternative approach I'm trying.

@MangelMaxime
Copy link
Member

I am closing this PR has Alfonso released his solution of disguising the project has an csproj when doing the project cracking and it seems to have fixed the problem for Fable 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants