-
Notifications
You must be signed in to change notification settings - Fork 29
Need to implement mechanism for obtaining edit rights in *-che namespace #686
Comments
@ibuziuk sorry for long inactivity. Sadly, I haven't got to it yet because I got stuck by other issues with higher severity. |
@MatousJobanek @alexeykazakov any plans to handle this issue in the nearest future ? (the issue is related to https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/844) |
Hi @ibuziuk, I have the implementation for this feature done, but I cannot push it to master for now. The reason is that the implementation is built on top of the new tenant core logic that is currently in the develop branch and is deployed to prod-preview to test it in a real environment. Sorry for the delay. I hope that next week I could merge it. |
thanks for update @MatousJobanek ! |
@MatousJobanek hi, could you please provide some updates regarding this issue. It now becomes pretty important due to the fact that https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/844 was closed |
We are planning to merge #741 on Monday. It will fix this issue. |
@ibuziuk it's been merged, could you please verify that it works as expected in prod-preview? If it doesn't, please ping me in MM. Thanks |
@MatousJobanek @alexeykazakov could you please clarify what is the current flow for getting edit rights in |
@MatousJobanek seems to work just fine - great job \o/ Am I correct that this is already promoted to prod ? |
one thing I noticed - if identity is removed from toggle, update tenant does not seem to revoke edit rights. is it expected ? |
yes, this is exactly the expected flow
thank you, but it is not promoted to prod for now :-). It's just in prod-preview - please, try it there
the tenant should revoke the edit rights when the identity is removed from the toggle. the behavior that you observe is because you are in prod and not prod-preview. In prod, there is still the original template with the edit rights contained in it |
tested on prod-preview - all works just fine \o/ |
it's there @ibuziuk ;-) openshiftio/saas-openshiftio@493bfab |
need to implement mechanism that would allow to get edit rights for a particular user in their *-che namespace (edit rights in *-che namespace are required for developers). From the UX perspective mechanism should be the following:
che.edit.rights
withuserId
strategy enabled on prod / prod-previewidentity id
is added to the toggleupdate tenant
from the profile page onopenshift.io
and edit rights are granted in the *-che namespaceidentity id
is removed from the toggleupdate tenant
from the profile page onopenshift.io
and edit rights are revoked from the *-che namespaceThe text was updated successfully, but these errors were encountered: