Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Need to implement mechanism for obtaining edit rights in *-che namespace #686

Closed
ibuziuk opened this issue Nov 26, 2018 · 13 comments
Closed
Assignees
Milestone

Comments

@ibuziuk
Copy link
Contributor

ibuziuk commented Nov 26, 2018

need to implement mechanism that would allow to get edit rights for a particular user in their *-che namespace (edit rights in *-che namespace are required for developers). From the UX perspective mechanism should be the following:

  • Dedicated feature toggle e.g. che.edit.rights with userId strategy enabled on prod / prod-preview
  • identity id is added to the toggle
  • user presses update tenant from the profile page on openshift.io and edit rights are granted in the *-che namespace
  • identity id is removed from the toggle
  • user presses update tenant from the profile page on openshift.io and edit rights are revoked from the *-che namespace
@MatousJobanek MatousJobanek self-assigned this Nov 29, 2018
@MatousJobanek MatousJobanek added this to the Sprint 159 milestone Nov 29, 2018
@MatousJobanek
Copy link
Contributor

@ibuziuk sorry for long inactivity. Sadly, I haven't got to it yet because I got stuck by other issues with higher severity.
I should start working on it after the New Year

@xcoulon xcoulon modified the milestones: Sprint 159, Sprint 160 Jan 4, 2019
@xcoulon xcoulon modified the milestones: Sprint 160, Sprint 161 Jan 16, 2019
@ibuziuk
Copy link
Contributor Author

ibuziuk commented Jan 25, 2019

@MatousJobanek @alexeykazakov any plans to handle this issue in the nearest future ? (the issue is related to https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/844)

@MatousJobanek
Copy link
Contributor

Hi @ibuziuk,

I have the implementation for this feature done, but I cannot push it to master for now. The reason is that the implementation is built on top of the new tenant core logic that is currently in the develop branch and is deployed to prod-preview to test it in a real environment.
In other words, as soon as the new logic is stable, deeply tested and working for a few days without any problem, then I can merge it to master. And when it is merged then I can also make PR/merge the logic for dynamic adding/deletion of the edit rights.

Sorry for the delay. I hope that next week I could merge it.

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Jan 25, 2019

thanks for update @MatousJobanek !

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Feb 9, 2019

@MatousJobanek hi, could you please provide some updates regarding this issue. It now becomes pretty important due to the fact that https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/844 was closed

@alexeykazakov
Copy link
Contributor

We are planning to merge #741 on Monday. It will fix this issue.

@MatousJobanek
Copy link
Contributor

@ibuziuk it's been merged, could you please verify that it works as expected in prod-preview? If it doesn't, please ping me in MM. Thanks

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Feb 11, 2019

@MatousJobanek @alexeykazakov could you please clarify what is the current flow for getting edit rights in che namespace for a particular user ? add identity to toggle and press the update tenant button ?

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Feb 11, 2019

@MatousJobanek seems to work just fine - great job \o/ Am I correct that this is already promoted to prod ?

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Feb 11, 2019

one thing I noticed - if identity is removed from toggle, update tenant does not seem to revoke edit rights. is it expected ?

@MatousJobanek
Copy link
Contributor

@ibuziuk

could you please clarify what is the current flow for getting edit rights in che namespace for a particular user ? add identity to toggle and press the update tenant button ?

yes, this is exactly the expected flow

seems to work just fine - great job \o/ Am I correct that this is already promoted to prod ?

thank you, but it is not promoted to prod for now :-). It's just in prod-preview - please, try it there

one thing I noticed - if identity is removed from toggle, update tenant does not seem to revoke edit rights. is it expected ?

the tenant should revoke the edit rights when the identity is removed from the toggle. the behavior that you observe is because you are in prod and not prod-preview. In prod, there is still the original template with the edit rights contained in it

@ibuziuk
Copy link
Contributor Author

ibuziuk commented Feb 12, 2019

tested on prod-preview - all works just fine \o/
huge +1 for promotion to prod

MatousJobanek added a commit to MatousJobanek/fabric8-tenant that referenced this issue Feb 15, 2019
@MatousJobanek
Copy link
Contributor

it's there @ibuziuk ;-) openshiftio/saas-openshiftio@493bfab

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants