This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
feat(#686): add/remove user-edit rolebinding in che based on toggle #741
Merged
MatousJobanek
merged 12 commits into
fabric8-services:master
from
MatousJobanek:issue-686-che-user-edit
Feb 11, 2019
Merged
feat(#686): add/remove user-edit rolebinding in che based on toggle #741
MatousJobanek
merged 12 commits into
fabric8-services:master
from
MatousJobanek:issue-686-che-user-edit
Feb 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes one or more of the template files. These changes are now available for testing: Launch in OpenShift.io and click the update tenant button |
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
=========================================
Coverage ? 75.46%
=========================================
Files ? 37
Lines ? 3037
Branches ? 0
=========================================
Hits ? 2292
Misses ? 557
Partials ? 188
Continue to review full report at Codecov.
|
MatousJobanek
changed the title
WIP feat(#686): add/remove user-edit rolebinding in che based on toggle
feat(#686): add/remove user-edit rolebinding in che based on toggle
Feb 5, 2019
This PR changes one or more of the template files. These changes are now available for testing: Launch in OpenShift.io and click the update tenant button |
alexeykazakov
approved these changes
Feb 8, 2019
MatousJobanek
added a commit
to MatousJobanek/fabric8-tenant
that referenced
this pull request
Feb 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the information whether the user has
che.edit.rights
toggle enabled it adds or removes theuser-edit
rolebinding for the che namespace. The body that is sent to OS (when doingPOST
) is:Fixes: #686