Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

feat(#686): add/remove user-edit rolebinding in che based on toggle #741

Merged

Conversation

MatousJobanek
Copy link
Contributor

@MatousJobanek MatousJobanek commented Jan 29, 2019

based on the information whether the user has che.edit.rights toggle enabled it adds or removes the user-edit rolebinding for the che namespace. The body that is sent to OS (when doing POST) is:

kind: RoleBinding
metadata:
  name: user-edit
  namespace: ${ns-base-name}-che
roleRef:
  name: edit
subjects:
- kind: User
  name: ${os-username}
userNames:
- ${os-username}

Fixes: #686

@fabric8cd
Copy link
Contributor

This PR changes one or more of the template files. These changes are now available for testing: Launch in OpenShift.io and click the update tenant button

@fabric8-services fabric8-services deleted a comment from fabric8cd Jan 29, 2019
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9c2ea27). Click here to learn what that means.
The diff coverage is 81.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #741   +/-   ##
=========================================
  Coverage          ?   75.46%           
=========================================
  Files             ?       37           
  Lines             ?     3037           
  Branches          ?        0           
=========================================
  Hits              ?     2292           
  Misses            ?      557           
  Partials          ?      188
Impacted Files Coverage Δ
auth/service.go 73.73% <ø> (ø)
toggles/toggles.go 30.61% <ø> (ø)
controller/convert.go 100% <100%> (ø)
jsonapi/jsonapi_utility.go 70.1% <100%> (ø)
configuration/configuration.go 71.25% <100%> (ø)
migration/migration.go 38.13% <100%> (ø)
controller/update.go 69.14% <100%> (ø)
controller/tenants.go 63.96% <46.87%> (ø)
environment/template.go 88.4% <50%> (ø)
controller/tenant.go 71.05% <71.13%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2ea27...ddf4bcb. Read the comment docs.

@MatousJobanek MatousJobanek changed the title WIP feat(#686): add/remove user-edit rolebinding in che based on toggle feat(#686): add/remove user-edit rolebinding in che based on toggle Feb 5, 2019
@MatousJobanek MatousJobanek changed the base branch from develop to master February 6, 2019 14:17
@fabric8cd
Copy link
Contributor

This PR changes one or more of the template files. These changes are now available for testing: Launch in OpenShift.io and click the update tenant button

@MatousJobanek MatousJobanek merged commit 5f58fb3 into fabric8-services:master Feb 11, 2019
MatousJobanek added a commit to MatousJobanek/fabric8-tenant that referenced this pull request Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants