Skip to content

Commit

Permalink
fix(extensions): Extension Jars don't contain META-INF/jandex.idx f…
Browse files Browse the repository at this point in the history
…ile (#3761)

Unlike `kubernetes-client`/`openshift-client` modules whose jars are
generated via maven jar plugin; Extension jars seem to be generated via
maven bundle plugin. Add an entry for `jandex.idx` file to extension
parent pom which would be included by client and model modules'
`Include-Resource` properties.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
  • Loading branch information
rohanKanojia committed Jan 19, 2022
1 parent 28151ed commit a235fc6
Show file tree
Hide file tree
Showing 29 changed files with 34 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* Fix #3679: output additionalProperties field with correct value type for map-like fields (CRD Generator)
* Fix #3648: `Serialization.unmarshal` fails to deserialize YAML with single document in presence of document delimiter(`---`)
* Fix #3568: Pod file upload fails if the path is `/`
* Fix #3761: Extension Jar packages don't contain the META-INF/jandex.idx index file

#### Improvements
* Fix #3674: allows the connect and websocket timeouts to apply to watches instead of a hardcoded timeout
Expand Down
1 change: 1 addition & 0 deletions extensions/camel-k/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
io.fabric8.camelk.client.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter=target/classes/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter
</osgi.include.resources>
</properties>
Expand Down
1 change: 1 addition & 0 deletions extensions/camel-k/model-v1/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
io.fabric8.camelk.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/camel-k-v1.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/camel-k/model-v1alpha1/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
io.fabric8.camelk.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/camel-k-v1alpha1.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/certmanager/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
io.fabric8.certmanager.client.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter=target/classes/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter
</osgi.include.resources>
</properties>
Expand Down
1 change: 1 addition & 0 deletions extensions/certmanager/model-v1/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
io.fabric8.certmanager.api.model.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model-v1.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/certmanager/model-v1alpha2/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
io.fabric8.certmanager.api.model.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model-v1alpha2.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/certmanager/model-v1alpha3/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
io.fabric8.certmanager.api.model.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model-v1alpha3.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/certmanager/model-v1beta1/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
io.fabric8.certmanager.api.model.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model-v1beta1.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/chaosmesh/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
io.fabric8.chaosmesh.client.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter=target/classes/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter
</osgi.include.resources>
</properties>
Expand Down
1 change: 1 addition & 0 deletions extensions/chaosmesh/model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
io.fabric8.chaosmesh.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/istio/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
io.fabric8.istio.client.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter=target/classes/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter,
</osgi.include.resources>
</properties>
Expand Down
1 change: 1 addition & 0 deletions extensions/istio/model-v1alpha3/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
io.fabric8.istio.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/istio/model-v1beta1/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
io.fabric8.istio.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/knative/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
io.fabric8.knative.client.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter=target/classes/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter,
</osgi.include.resources>
</properties>
Expand Down
1 change: 1 addition & 0 deletions extensions/knative/model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
io.fabric8.knative.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
6 changes: 6 additions & 0 deletions extensions/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@
<packaging>pom</packaging>
<name>Fabric8 :: Kubernetes :: Extensions</name>

<properties>
<osgi.include.resources.default>
/META-INF/jandex.idx=target/classes/META-INF/jandex.idx
</osgi.include.resources.default>
</properties>

<modules>
<module>knative</module>
<module>tekton</module>
Expand Down
1 change: 1 addition & 0 deletions extensions/service-catalog/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
io.fabric8.servicecatalog.client.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter=target/classes/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter
</osgi.include.resources>
</properties>
Expand Down
1 change: 1 addition & 0 deletions extensions/service-catalog/model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
io.fabric8.servicecatalog.api.model.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/tekton/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
io.fabric8.tekton.client.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter=target/classes/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter
</osgi.include.resources>
</properties>
Expand Down
1 change: 1 addition & 0 deletions extensions/tekton/model-triggers/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
io.fabric8.tekton.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/tekton-triggers.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/tekton/model-v1alpha1/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
io.fabric8.tekton.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/tekton-v1alpha1.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/tekton/model-v1beta1/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
io.fabric8.tekton.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/tekton-v1beta1.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/verticalpodautoscaler/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
io.fabric8.verticalpodautoscaler.client.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter=target/classes/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter
</osgi.include.resources>
</properties>
Expand Down
1 change: 1 addition & 0 deletions extensions/verticalpodautoscaler/model-v1/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
io.fabric8.verticalpodautoscaler.api.model.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model-v1.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/volcano/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
io.fabric8.volcano.client.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter=target/classes/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter
</osgi.include.resources>
</properties>
Expand Down
1 change: 1 addition & 0 deletions extensions/volcano/model-v1beta1/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
io.fabric8.volcano.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model-v1beta1.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down
1 change: 1 addition & 0 deletions extensions/volumesnapshot/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
io.fabric8.volumesnapshot.client.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter=target/classes/META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter
</osgi.include.resources>
</properties>
Expand Down
1 change: 1 addition & 0 deletions extensions/volumesnapshot/model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
io.fabric8.volumesnapshot.api.model.*
</osgi.export>
<osgi.include.resources>
${osgi.include.resources.default},
{maven-resources},
/model.properties=target/classes/model.properties
</osgi.include.resources>
Expand Down

0 comments on commit a235fc6

Please sign in to comment.