Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Jar packages don't contain the META-INF/jandex.idx index file #3761

Closed
manusa opened this issue Jan 19, 2022 · 1 comment · Fixed by #3771
Closed

Extension Jar packages don't contain the META-INF/jandex.idx index file #3761

manusa opened this issue Jan 19, 2022 · 1 comment · Fixed by #3771
Assignees
Labels
Milestone

Comments

@manusa
Copy link
Member

manusa commented Jan 19, 2022

Describe the bug

The bundling configuration for the extension modules is not considering the META-INF/jandex.idx file.

Fabric8 Kubernetes Client version

other (please specify in additional context)

Steps to reproduce

mvn package

target/classes/META-INF contains a valid jandex.idx file

target/$artifact-$version.jar archive doesn't contain the META-INF/jandex.idx file

Expected behavior

target/$artifact-$version.jar should contain the META-INF/jandex.idx file

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

other (please specify in additional context)

Environment

other (please specify in additional context)

Fabric8 Kubernetes Client Logs

No response

Additional context

No response

@manusa manusa added this to the 5.12.0 milestone Jan 19, 2022
@manusa manusa added the bug label Jan 19, 2022
@rohanKanojia rohanKanojia self-assigned this Jan 19, 2022
@rohanKanojia
Copy link
Member

rohanKanojia commented Jan 19, 2022

If we just add this property to each extension model/client module; META-INF/jandex.idx file should be included in the generated jar file

    <properties>
        <osgi.include.resources>
          /META-INF/jandex.idx=target/classes/META-INF/jandex.idx
        </osgi.include.resources>
    </properties>

rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Jan 19, 2022
…ile (fabric8io#3761)

Unlike `kubernetes-client`/`openshift-client` modules whose jars are
generated via maven jar plugin; Extension jars seem to be generated via
maven bundle plugin. Add an entry for `jandex.idx` file to extension
parent pom which would be included by client and model modules'
`Include-Resource` properties.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit to rohanKanojia/kubernetes-client that referenced this issue Jan 21, 2022
…ile (fabric8io#3761)

Unlike `kubernetes-client`/`openshift-client` modules whose jars are
generated via maven jar plugin; Extension jars seem to be generated via
maven bundle plugin. Add an entry for `jandex.idx` file to extension
parent pom which would be included by client and model modules'
`Include-Resource` properties.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Jan 21, 2022
…ile (#3761)

Unlike `kubernetes-client`/`openshift-client` modules whose jars are
generated via maven jar plugin; Extension jars seem to be generated via
maven bundle plugin. Add an entry for `jandex.idx` file to extension
parent pom which would be included by client and model modules'
`Include-Resource` properties.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants