fix(extensions): Extension Jars don't contain META-INF/jandex.idx file (#3761)
#3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 19, 2022
…ile (fabric8io#3761) Unlike `kubernetes-client`/`openshift-client` modules whose jars are generated via maven jar plugin; Extension jars seem to be generated via maven bundle plugin. Add an entry for `jandex.idx` file to extension parent pom which would be included by client and model modules' `Include-Resource` properties. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
approved these changes
Jan 21, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #3761
Unlike
kubernetes-client/openshift-clientmodules whose jars aregenerated via maven jar plugin; Extension jars seem to be generated via
maven bundle plugin. Add an entry for
jandex.idxfile to extensionparent pom which would be included by client and model modules'
Include-Resourceproperties.Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist