-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod.evict return and exception handling #3853
Milestone
Comments
manusa
pushed a commit
to shawkins/kubernetes-client
that referenced
this issue
Feb 22, 2022
fixing extension references
manusa
pushed a commit
to shawkins/kubernetes-client
that referenced
this issue
Feb 22, 2022
manusa
pushed a commit
to shawkins/kubernetes-client
that referenced
this issue
Feb 22, 2022
fixing extension references
manusa
pushed a commit
to shawkins/kubernetes-client
that referenced
this issue
Feb 22, 2022
manusa
pushed a commit
that referenced
this issue
Feb 22, 2022
I don't think #3844 takes care of this issue |
No, this issue hasn't been worked yet. |
Other places in the api returning Boolean should likewise be changed to boolean - unless for some reason three valued logic is expected. |
This will need to wait until #3845 to reduce conflicts. |
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this issue
Mar 2, 2022
shawkins
added a commit
to shawkins/kubernetes-client
that referenced
this issue
Mar 2, 2022
11 tasks
manusa
pushed a commit
that referenced
this issue
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your enhancement related to a problem? Please describe
Pod.evict returns Boolean, but can only be two valued. The 429 is indistinguishable from a 404 - in most other api calls 404 would be an exception.
Describe the solution you'd like
It should return a boolean and throw an exception on a 404.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: