Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3853: replacing Boolean with boolean and throwing a 404 from evict #3919

Merged
merged 2 commits into from
Mar 7, 2022
Merged

fix #3853: replacing Boolean with boolean and throwing a 404 from evict #3919

merged 2 commits into from
Mar 7, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Mar 2, 2022

Description

To eliminate the possibility of null, Boolean is being replaced by boolean where appropriate in the api. Also throwing a 404 from evict to differentiate from eviction failure.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins linked an issue Mar 2, 2022 that may be closed by this pull request
Pod.evict return and exception handling #3853
Closed
@manusa manusa added this to the 6.0.0 milestone Mar 7, 2022
@manusa
test: evict throws Exception when Pod not found
b6491f3 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

33.3% 33.3% Coverage
11.3% 11.3% Duplication

@manusa manusa merged commit 2567140 into fabric8io:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Pod.evict return and exception handling
4 participants
@shawkins @manusa @oscerd @rohanKanojia