Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve imported CSS files from anywhere #105

Merged
merged 2 commits into from
Jul 23, 2016
Merged

Resolve imported CSS files from anywhere #105

merged 2 commits into from
Jul 23, 2016

Conversation

glennreyes
Copy link
Contributor

@glennreyes glennreyes commented Jul 22, 2016 •
edited
Loading

@ghost
Copy link

ghost commented Jul 22, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

gaearon
gaearon reviewed Jul 22, 2016
View reviewed changes
config/webpack.config.dev.js
@@ -67,7 +67,6 @@ module.exports = {
},
{
test: /\.css$/,
include: srcPath,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's explicitly include srcPath and related node_modules folder. This helps us know for sure where things may be located.

@glennreyes
Copy link
Contributor Author

@gaearon I've just updated the PR

@mxstbr
Copy link
Contributor

mxstbr commented Jul 23, 2016

Awesome, thanks Glenn!

@mxstbr mxstbr merged commit a35ac92 into facebook:master Jul 23, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 23, 2016

@glennreyes Just noticed CLA label isn’t set, can you sign the CLA please? See #105 (comment).

@glennreyes
Copy link
Contributor Author

@gaearon Sure... done ;)

@gaearon
Copy link
Contributor

gaearon commented Jul 23, 2016

Thanks!

@mxstbr
Copy link
Contributor

mxstbr commented Jul 24, 2016

Sorry, my bad @gaearon!

@glennreyes glennreyes deleted the remove-css-include-filter branch July 24, 2016 12:15
@breaddevil
Copy link
Contributor

Hi,
It looks like the node_modules folder added (nodeModulesPath) is the one relative to the react-script inner module (unless the config has been ejected).

A more flexible path could be
path.resolve(__dirname, relativePath, 'node_modules');

@gaearon gaearon added this to the 0.2.0 milestone Jul 25, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 25, 2016

Oops, good catch. @breaddevil Would you like to make a PR?

@glennreyes
Copy link
Contributor Author

Good catch @breaddevil! 👍

@gaearon gaearon mentioned this pull request Jul 27, 2016
Merged
grengojbo pushed a commit to grengojbo/es6-react-scripts that referenced this pull request Nov 18, 2017
@kitze
Merge pull request facebook#105 from gr33k01/master
de5a2f6 
Addresses issue where build script doesn't terminate automatically as…
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@glennreyes @mxstbr @gaearon @breaddevil